* [PATCH] mmc: export function mmc_do_release_host
@ 2011-03-05 13:07 Linus Walleij
2011-03-08 19:20 ` Linus Walleij
2011-03-08 19:44 ` Chris Ball
0 siblings, 2 replies; 6+ messages in thread
From: Linus Walleij @ 2011-03-05 13:07 UTC (permalink / raw)
To: linux-mmc, Chris Ball; +Cc: Lee Jones, Ulf Hansson, Linus Walleij
From: Ulf Hansson <ulf.hansson@stericsson.com>
When using mmc_try_claim_host the corresponding release
function is mmc_do_release_host, which then also must
be exported.
Reviewed-by: Jonas Aberg <jonas.aberg@stericsson.com>
Reviewed-by: Sebastian Rasmussen <sebastian.rasmussen@stericsson.com>
Signed-off-by: Ulf Hansson <ulf.hansson@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/mmc/core/core.c | 3 ++-
include/linux/mmc/core.h | 1 +
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 579ba1e..2521794 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -527,7 +527,7 @@ int mmc_try_claim_host(struct mmc_host *host)
}
EXPORT_SYMBOL(mmc_try_claim_host);
-static void mmc_do_release_host(struct mmc_host *host)
+void mmc_do_release_host(struct mmc_host *host)
{
unsigned long flags;
@@ -542,6 +542,7 @@ static void mmc_do_release_host(struct mmc_host *host)
wake_up(&host->wq);
}
}
+EXPORT_SYMBOL(mmc_do_release_host);
void mmc_host_deeper_disable(struct work_struct *work)
{
diff --git a/include/linux/mmc/core.h b/include/linux/mmc/core.h
index 64e013f..07f27af 100644
--- a/include/linux/mmc/core.h
+++ b/include/linux/mmc/core.h
@@ -160,6 +160,7 @@ extern unsigned int mmc_align_data_size(struct mmc_card *, unsigned int);
extern int __mmc_claim_host(struct mmc_host *host, atomic_t *abort);
extern void mmc_release_host(struct mmc_host *host);
+extern void mmc_do_release_host(struct mmc_host *host);
extern int mmc_try_claim_host(struct mmc_host *host);
/**
--
1.7.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: export function mmc_do_release_host
2011-03-05 13:07 [PATCH] mmc: export function mmc_do_release_host Linus Walleij
@ 2011-03-08 19:20 ` Linus Walleij
2011-03-08 19:40 ` Chris Ball
2011-03-08 19:44 ` Chris Ball
1 sibling, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2011-03-08 19:20 UTC (permalink / raw)
To: linux-mmc, Chris Ball
2011/3/5 Linus Walleij <linus.walleij@stericsson.com>:
> From: Ulf Hansson <ulf.hansson@stericsson.com>
>
> When using mmc_try_claim_host the corresponding release
> function is mmc_do_release_host, which then also must
> be exported.
Is this one OK Chris? Not much said about it but looks
harmless to me...
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: export function mmc_do_release_host
2011-03-08 19:20 ` Linus Walleij
@ 2011-03-08 19:40 ` Chris Ball
0 siblings, 0 replies; 6+ messages in thread
From: Chris Ball @ 2011-03-08 19:40 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-mmc
Hi Linus,
On Tue, Mar 08 2011, Linus Walleij wrote:
> 2011/3/5 Linus Walleij <linus.walleij@stericsson.com>:
>
>> From: Ulf Hansson <ulf.hansson@stericsson.com>
>>
>> When using mmc_try_claim_host the corresponding release
>> function is mmc_do_release_host, which then also must
>> be exported.
>
> Is this one OK Chris? Not much said about it but looks
> harmless to me...
Yes, they're both in my queue and look reasonable to me; I'm just giving
people a chance to comment on them (it's only been one full business day
since these were submitted!) before merging.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: export function mmc_do_release_host
2011-03-05 13:07 [PATCH] mmc: export function mmc_do_release_host Linus Walleij
2011-03-08 19:20 ` Linus Walleij
@ 2011-03-08 19:44 ` Chris Ball
1 sibling, 0 replies; 6+ messages in thread
From: Chris Ball @ 2011-03-08 19:44 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-mmc, Lee Jones, Ulf Hansson, Linus Walleij
Hi,
On Sat, Mar 05 2011, Linus Walleij wrote:
> From: Ulf Hansson <ulf.hansson@stericsson.com>
>
> When using mmc_try_claim_host the corresponding release
> function is mmc_do_release_host, which then also must
> be exported.
>
> Reviewed-by: Jonas Aberg <jonas.aberg@stericsson.com>
> Reviewed-by: Sebastian Rasmussen <sebastian.rasmussen@stericsson.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@stericsson.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/mmc/core/core.c | 3 ++-
> include/linux/mmc/core.h | 1 +
> 2 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index 579ba1e..2521794 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -527,7 +527,7 @@ int mmc_try_claim_host(struct mmc_host *host)
> }
> EXPORT_SYMBOL(mmc_try_claim_host);
>
> -static void mmc_do_release_host(struct mmc_host *host)
> +void mmc_do_release_host(struct mmc_host *host)
> {
> unsigned long flags;
>
> @@ -542,6 +542,7 @@ static void mmc_do_release_host(struct mmc_host *host)
> wake_up(&host->wq);
> }
> }
> +EXPORT_SYMBOL(mmc_do_release_host);
>
> void mmc_host_deeper_disable(struct work_struct *work)
> {
Would you mind adding a kerneldoc comment for mmc_do_release_host()?
The other public locking functions have them, so this should gain one
too when it becomes public.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] mmc: export function mmc_do_release_host
@ 2011-03-09 8:11 Linus Walleij
2011-03-10 15:27 ` Chris Ball
0 siblings, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2011-03-09 8:11 UTC (permalink / raw)
To: linux-mmc, Chris Ball; +Cc: Lee Jones, Ulf Hansson, Linus Walleij
From: Ulf Hansson <ulf.hansson@stericsson.com>
When using mmc_try_claim_host the corresponding release
function is mmc_do_release_host, which then also must
be exported.
Reviewed-by: Jonas Aberg <jonas.aberg@stericsson.com>
Reviewed-by: Sebastian Rasmussen <sebastian.rasmussen@stericsson.com>
Signed-off-by: Ulf Hansson <ulf.hansson@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
V2: updated with kerneldoc
---
drivers/mmc/core/core.c | 10 +++++++++-
include/linux/mmc/core.h | 1 +
2 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 6625c05..0178fca 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -528,7 +528,14 @@ int mmc_try_claim_host(struct mmc_host *host)
}
EXPORT_SYMBOL(mmc_try_claim_host);
-static void mmc_do_release_host(struct mmc_host *host)
+/**
+ * mmc_do_release_host - release a claimed host
+ * @host: mmc host to release
+ *
+ * If you successfully claimed a host, this function will
+ * release it again.
+ */
+void mmc_do_release_host(struct mmc_host *host)
{
unsigned long flags;
@@ -543,6 +550,7 @@ static void mmc_do_release_host(struct mmc_host *host)
wake_up(&host->wq);
}
}
+EXPORT_SYMBOL(mmc_do_release_host);
void mmc_host_deeper_disable(struct work_struct *work)
{
diff --git a/include/linux/mmc/core.h b/include/linux/mmc/core.h
index 64e013f..07f27af 100644
--- a/include/linux/mmc/core.h
+++ b/include/linux/mmc/core.h
@@ -160,6 +160,7 @@ extern unsigned int mmc_align_data_size(struct mmc_card *, unsigned int);
extern int __mmc_claim_host(struct mmc_host *host, atomic_t *abort);
extern void mmc_release_host(struct mmc_host *host);
+extern void mmc_do_release_host(struct mmc_host *host);
extern int mmc_try_claim_host(struct mmc_host *host);
/**
--
1.7.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: export function mmc_do_release_host
2011-03-09 8:11 Linus Walleij
@ 2011-03-10 15:27 ` Chris Ball
0 siblings, 0 replies; 6+ messages in thread
From: Chris Ball @ 2011-03-10 15:27 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-mmc, Lee Jones, Ulf Hansson, Linus Walleij
Hi,
On Wed, Mar 09 2011, Linus Walleij wrote:
> From: Ulf Hansson <ulf.hansson@stericsson.com>
>
> When using mmc_try_claim_host the corresponding release
> function is mmc_do_release_host, which then also must
> be exported.
>
> Reviewed-by: Jonas Aberg <jonas.aberg@stericsson.com>
> Reviewed-by: Sebastian Rasmussen <sebastian.rasmussen@stericsson.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@stericsson.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> V2: updated with kerneldoc
Thanks, pushed to mmc-next for .39.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-10 15:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-05 13:07 [PATCH] mmc: export function mmc_do_release_host Linus Walleij
2011-03-08 19:20 ` Linus Walleij
2011-03-08 19:40 ` Chris Ball
2011-03-08 19:44 ` Chris Ball
-- strict thread matches above, loose matches on Subject: below --
2011-03-09 8:11 Linus Walleij
2011-03-10 15:27 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox