[PATCH] mmc: export function mmc_do_release_host

[PATCH] mmc: export function mmc_do_release_host

[Linus Walleij]

From: Ulf Hansson <ulf.hansson@stericsson.com>

When using mmc_try_claim_host the corresponding release
function is mmc_do_release_host, which then also must
be exported.

Reviewed-by: Jonas Aberg <jonas.aberg@stericsson.com>
Reviewed-by: Sebastian Rasmussen <sebastian.rasmussen@stericsson.com>
Signed-off-by: Ulf Hansson <ulf.hansson@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/mmc/core/core.c  |    3 ++-
 include/linux/mmc/core.h |    1 +
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 579ba1e..2521794 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -527,7 +527,7 @@ int mmc_try_claim_host(struct mmc_host *host)
 }
 EXPORT_SYMBOL(mmc_try_claim_host);
 
-static void mmc_do_release_host(struct mmc_host *host)
+void mmc_do_release_host(struct mmc_host *host)
 {
 	unsigned long flags;
 
@@ -542,6 +542,7 @@ static void mmc_do_release_host(struct mmc_host *host)
 		wake_up(&host->wq);
 	}
 }
+EXPORT_SYMBOL(mmc_do_release_host);
 
 void mmc_host_deeper_disable(struct work_struct *work)
 {
diff --git a/include/linux/mmc/core.h b/include/linux/mmc/core.h
index 64e013f..07f27af 100644
--- a/include/linux/mmc/core.h
+++ b/include/linux/mmc/core.h
@@ -160,6 +160,7 @@ extern unsigned int mmc_align_data_size(struct mmc_card *, unsigned int);
 
 extern int __mmc_claim_host(struct mmc_host *host, atomic_t *abort);
 extern void mmc_release_host(struct mmc_host *host);
+extern void mmc_do_release_host(struct mmc_host *host);
 extern int mmc_try_claim_host(struct mmc_host *host);
 
 /**
-- 
1.7.3.2

Re: [PATCH] mmc: export function mmc_do_release_host

[Linus Walleij]

2011/3/5 Linus Walleij <linus.walleij@stericsson.com>:

> From: Ulf Hansson <ulf.hansson@stericsson.com>
>
> When using mmc_try_claim_host the corresponding release
> function is mmc_do_release_host, which then also must
> be exported.

Is this one OK Chris? Not much said about it but looks
harmless to me...

Linus Walleij

Re: [PATCH] mmc: export function mmc_do_release_host

[Chris Ball]

Hi Linus,

On Tue, Mar 08 2011, Linus Walleij wrote:
> 2011/3/5 Linus Walleij <linus.walleij@stericsson.com>:
>
>> From: Ulf Hansson <ulf.hansson@stericsson.com>
>>
>> When using mmc_try_claim_host the corresponding release
>> function is mmc_do_release_host, which then also must
>> be exported.
>
> Is this one OK Chris? Not much said about it but looks
> harmless to me...

Yes, they're both in my queue and look reasonable to me; I'm just giving
people a chance to comment on them (it's only been one full business day
since these were submitted!) before merging.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

Re: [PATCH] mmc: export function mmc_do_release_host

[Chris Ball]

Hi,

On Sat, Mar 05 2011, Linus Walleij wrote:
> From: Ulf Hansson <ulf.hansson@stericsson.com>
>
> When using mmc_try_claim_host the corresponding release
> function is mmc_do_release_host, which then also must
> be exported.
>
> Reviewed-by: Jonas Aberg <jonas.aberg@stericsson.com>
> Reviewed-by: Sebastian Rasmussen <sebastian.rasmussen@stericsson.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@stericsson.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/mmc/core/core.c  |    3 ++-
>  include/linux/mmc/core.h |    1 +
>  2 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index 579ba1e..2521794 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -527,7 +527,7 @@ int mmc_try_claim_host(struct mmc_host *host)
>  }
>  EXPORT_SYMBOL(mmc_try_claim_host);
>  
> -static void mmc_do_release_host(struct mmc_host *host)
> +void mmc_do_release_host(struct mmc_host *host)
>  {
>  	unsigned long flags;
>  
> @@ -542,6 +542,7 @@ static void mmc_do_release_host(struct mmc_host *host)
>  		wake_up(&host->wq);
>  	}
>  }
> +EXPORT_SYMBOL(mmc_do_release_host);
>  
>  void mmc_host_deeper_disable(struct work_struct *work)
>  {

Would you mind adding a kerneldoc comment for mmc_do_release_host()?
The other public locking functions have them, so this should gain one
too when it becomes public.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

[PATCH] mmc: export function mmc_do_release_host

[Linus Walleij]

From: Ulf Hansson <ulf.hansson@stericsson.com>

When using mmc_try_claim_host the corresponding release
function is mmc_do_release_host, which then also must
be exported.

Reviewed-by: Jonas Aberg <jonas.aberg@stericsson.com>
Reviewed-by: Sebastian Rasmussen <sebastian.rasmussen@stericsson.com>
Signed-off-by: Ulf Hansson <ulf.hansson@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
V2: updated with kerneldoc
---
 drivers/mmc/core/core.c  |   10 +++++++++-
 include/linux/mmc/core.h |    1 +
 2 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 6625c05..0178fca 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -528,7 +528,14 @@ int mmc_try_claim_host(struct mmc_host *host)
 }
 EXPORT_SYMBOL(mmc_try_claim_host);
 
-static void mmc_do_release_host(struct mmc_host *host)
+/**
+ *	mmc_do_release_host - release a claimed host
+ *	@host: mmc host to release
+ *
+ *	If you successfully claimed a host, this function will
+ *	release it again.
+ */
+void mmc_do_release_host(struct mmc_host *host)
 {
 	unsigned long flags;
 
@@ -543,6 +550,7 @@ static void mmc_do_release_host(struct mmc_host *host)
 		wake_up(&host->wq);
 	}
 }
+EXPORT_SYMBOL(mmc_do_release_host);
 
 void mmc_host_deeper_disable(struct work_struct *work)
 {
diff --git a/include/linux/mmc/core.h b/include/linux/mmc/core.h
index 64e013f..07f27af 100644
--- a/include/linux/mmc/core.h
+++ b/include/linux/mmc/core.h
@@ -160,6 +160,7 @@ extern unsigned int mmc_align_data_size(struct mmc_card *, unsigned int);
 
 extern int __mmc_claim_host(struct mmc_host *host, atomic_t *abort);
 extern void mmc_release_host(struct mmc_host *host);
+extern void mmc_do_release_host(struct mmc_host *host);
 extern int mmc_try_claim_host(struct mmc_host *host);
 
 /**
-- 
1.7.3.2

Re: [PATCH] mmc: export function mmc_do_release_host

[Chris Ball]

Hi,

On Wed, Mar 09 2011, Linus Walleij wrote:
> From: Ulf Hansson <ulf.hansson@stericsson.com>
>
> When using mmc_try_claim_host the corresponding release
> function is mmc_do_release_host, which then also must
> be exported.
>
> Reviewed-by: Jonas Aberg <jonas.aberg@stericsson.com>
> Reviewed-by: Sebastian Rasmussen <sebastian.rasmussen@stericsson.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@stericsson.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> V2: updated with kerneldoc

Thanks, pushed to mmc-next for .39.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child