From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission Date: Mon, 14 Mar 2011 23:01:46 -0400 Message-ID: References: <20B0EAA71DD7413A9A29D0493C6C1D87@AN00536> <20101116150022.GA27726@void.printf.net> <27884BED0E3C489C8849EE12A803F536@AN00536> <4CE41BE3.1060806@elandigitalsystems.com> <4CEA86D4.9050109@elandigitalsystems.com> <1295607004.1816.6.camel@apple-mac> <1299773604.1682.21.camel@apple-mac> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from void.printf.net ([89.145.121.20]:46296 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750807Ab1CODE2 (ORCPT ); Mon, 14 Mar 2011 23:04:28 -0400 In-Reply-To: <1299773604.1682.21.camel@apple-mac> (Tony Olech's message of "Thu, 10 Mar 2011 16:13:24 +0000") Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Tony Olech Cc: linux-mmc@vger.kernel.org Hi, On Thu, Mar 10 2011, Tony Olech wrote: > Add a driver for Elan Digital System's VUB300 chip > which is a USB connected SDIO/SDmem/MMC host controller. > A VUB300 chip enables a USB 2.0 or USB 1.1 connected host > computer to use SDIO/SD/MMC cards without the need for > a directly connected, for example via PCI, SDIO host > controller. > > Signed-off-by: Anthony F Olech linux-mmc@ folks, any strong opinions on this driver? My impression is that it looks reasonable, but has some areas of being pretty far from standard CodingStyle. I'm leaning towards merging it as-is and then working on incremental fixes; please yell if that sounds like a bad idea. Thanks, - Chris. -- Chris Ball One Laptop Per Child