From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH 1/6] mmc: sdhci-pxav3: fix build error Date: Tue, 18 Sep 2012 22:47:20 -0400 Message-ID: References: <1348020762-12932-1-git-send-email-keyuan.liu@gmail.com> <1348020762-12932-2-git-send-email-keyuan.liu@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from void.printf.net ([89.145.121.20]:60939 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755369Ab2ISCrF (ORCPT ); Tue, 18 Sep 2012 22:47:05 -0400 In-Reply-To: <1348020762-12932-2-git-send-email-keyuan.liu@gmail.com> (Kevin Liu's message of "Wed, 19 Sep 2012 10:12:37 +0800") Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Kevin Liu Cc: linux-mmc@vger.kernel.org, pierre@ossman.eu, hzhuang1@marvell.com, cxie4@marvell.com, prakity@marvell.com, kliu5@marvell.com Hi, On Tue, Sep 18 2012, Kevin Liu wrote: > From: Kevin Liu > > Commit 18c75479 introduced build error with slot-gpio.h missing > and pdata undeclared > > Signed-off-by: Kevin Liu > --- > drivers/mmc/host/sdhci-pxav3.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c > index 223a5d4..f69d6c1 100644 > --- a/drivers/mmc/host/sdhci-pxav3.c > +++ b/drivers/mmc/host/sdhci-pxav3.c > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include > > #include "sdhci.h" > #include "sdhci-pltfm.h" > @@ -317,6 +318,7 @@ static int __devexit sdhci_pxav3_remove(struct platform_device *pdev) > struct sdhci_host *host = platform_get_drvdata(pdev); > struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > struct sdhci_pxa *pxa = pltfm_host->priv; > + struct sdhci_pxa_platdata *pdata = pdev->dev.platform_data; > > sdhci_remove_host(host, 1); Thanks very much for catching this, Kevin -- I'll fold this change into the original patch to avoid breaking bisection. - Chris. -- Chris Ball One Laptop Per Child