From: Chris Ball <cjb@laptop.org>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: linux-mmc@vger.kernel.org
Subject: Re: [PATCH] MMC: Standardize header file multiple inclusion checks.
Date: Fri, 27 May 2011 12:48:33 -0400 [thread overview]
Message-ID: <m3aae8rswu.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1105270803340.3939@localhost6.localdomain6> (Robert P. J. Day's message of "Fri, 27 May 2011 08:07:07 -0400 (EDT)")
Hi,
On Fri, May 27 2011, Robert P. J. Day wrote:
> Standardize the form of MMC header file inclusion checks, add missing
> comments at end, fix one incorrect comment at end of file.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> obviously just aesthetic changes but they do conform to the norm for
> header file inclusion checks. someone here can decide whether or not
> to apply them. not compile-tested as they are all fairly
> self-evident.
Thanks, works for me. Your two-spaces-after-endif style is not the
norm, though -- want to resubmit with that changed to one space?
~/git/mmc/include/linux% git grep "endif /*" | wc -l
1497
~/git/mmc/include/linux% git grep "endif /*" | wc -l
24
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-05-27 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 12:07 [PATCH] MMC: Standardize header file multiple inclusion checks Robert P. J. Day
2011-05-27 16:48 ` Chris Ball [this message]
2011-05-27 16:51 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aae8rswu.fsf@pullcord.laptop.org \
--to=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox