From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH v6] mmc: Add mmc CMD+ACMD passthrough ioctl Date: Wed, 20 Apr 2011 18:28:48 -0400 Message-ID: References: <201104202117.14463.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from void.printf.net ([89.145.121.20]:37105 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751478Ab1DTWYm (ORCPT ); Wed, 20 Apr 2011 18:24:42 -0400 In-Reply-To: (John Calixto's message of "Wed, 20 Apr 2011 13:47:16 -0700 (PDT)") Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: John Calixto Cc: =?utf-8?Q?Micha=C5=82_Miros=C5=82aw?= , Arnd Bergmann , linux-mmc@vger.kernel.org, Andrei Warkentin Hi John, On Wed, Apr 20 2011, John Calixto wrote: > Do you have a preference here? I do not have a preference. On the one > hand, not having the union makes for a cleaner-to-read struct. On the > other hand, not having to cast the pointer in 32-bit userspace is nice > especially since I foresee using this ioctl on a lot of ARM SoCs. I'll defer to Arnd, which I guess suggests using the __u64 unless he comes around to the union idea. :) - Chris. -- Chris Ball One Laptop Per Child