public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: singh.madhav@samsung.com
Cc: linux-mmc@vger.kernel.org, kyungmin.park@samsung.com
Subject: Re: [PATCH RESEND] sdhci-clk-gating-support
Date: Fri, 02 Jul 2010 12:01:45 -0400	[thread overview]
Message-ID: <m3eiflx47q.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <23314024.108801278080144319.JavaMail.weblogic@epml07> (MADHAV SINGHCHAUHAN's message of "Fri, 02 Jul 2010 14:15:44 +0000 (GMT)")

Hi Madhav,

> +       host->user = 0;         /*For Clock gating*/
> +       host->clk_restore = 0;

Also, it's not obvious to me why two variables are necessary.  What's
wrong with just setting host->clk_restore when disabling clock, and
testing whether it's non-zero instead of testing host->user?
(host->user would need a more descriptive name, too.)

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>
One Laptop Per Child

  reply	other threads:[~2010-07-02 15:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-02 14:15 [PATCH RESEND] sdhci-clk-gating-support MADHAV SINGHCHAUHAN
2010-07-02 16:01 ` Chris Ball [this message]
2010-07-06  5:55   ` Madhav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3eiflx47q.fsf@pullcord.laptop.org \
    --to=cjb@laptop.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=singh.madhav@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox