Re: [PATCH v3] mmc: Add ioctl to let userspace apps send ACMDs

[Chris Ball <cjb@laptop.org>]

Hi John,

On Thu, Apr 07 2011, John Calixto wrote:
> Sending ACMDs from userspace is useful for such things as:
>
>     - The security application of an SD card (SD Specification, Part 3,
>       Security)
>
>     - SD passthrough for virtual machines
>
> Tested on TI PCIxx12 (SDHCI), Sigma Designs SMP8652 SoC, TI OMAP3621
> SoC, TI OMAP3630 SoC, Samsung S5PC110 SoC, Qualcomm MSM7200A SoC.
>
> Signed-off-by: John Calixto <john.calixto@modsystems.com>

This adds two gcc warnings here (compiling for ARM):

  CC      drivers/mmc/card/block.o
drivers/mmc/card/block.c: In function ‘mmc_blk_ioctl_copy_from_user’:
drivers/mmc/card/block.c:199:33: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
drivers/mmc/card/block.c: In function ‘mmc_blk_ioctl_acmd’:
drivers/mmc/card/block.c:308:20: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

...
> +	if (copy_from_user(idata->buf, (u8 *) user->data_ptr, idata->buf_bytes)) {
> +		err = -EFAULT;
> +		goto copy_err;
> +	}
...
> +		if (copy_to_user((u8 *) ic_ptr->data_ptr, idata->buf, idata->buf_bytes)) {
> +			err = -EFAULT;
> +			goto acmd_rel_host;
> +		}
...

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child