From: Chris Ball <cjb@laptop.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: "Shawn Guo" <shawn.guo@linaro.org>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Eric Bénard" <eric@eukrea.com>,
kernel@pengutronix.de
Subject: Re: [PATCH 3/3] mmc: esdhc i.MX: Support 8bit mode
Date: Tue, 25 Sep 2012 03:52:09 -0400 [thread overview]
Message-ID: <m3k3vilety.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <20120925073808.GZ1322@pengutronix.de> (Sascha Hauer's message of "Tue, 25 Sep 2012 09:38:08 +0200")
Hi,
On Tue, Sep 25 2012, Sascha Hauer wrote:
>> > > > +- bus-width : Maximum supported bus width. Defaults to 4 if omitted
>> > > >
>> > > This is a common mmc property documented in bindings/mmc/mmc.txt.
>> > > Instead of duplicating the documentation, we should try to make our
>> > > implementation conform to the common definition of the property.
>> >
>> > It is conform to the common definition, so all I have to do is drop the
>> > line duplicating the docs. That's easy ;)
>> >
>> Maybe not. The common binding defines it as a required property while
>> the patch implements it as an optional one.
>
> So you want to make the code conform to the common spec which has
> bus-width as a required property. Is this really worth it to add an
> incompatible change to our devicetrees?
We could also break the stalemate by just changing the common spec to
have bus-width become optional, default 4. It's not going to break the
code of anyone who's been treating it as required. I don't think there
there was a principled reason behind making it required.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-09-25 7:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 7:22 [PATCH] mmc: sdhci / i.MX esdhc buswidth patches Sascha Hauer
2012-09-24 7:22 ` [PATCH 1/3] mmc: sdhci: rename platform_8bit_width to platform_bus_width Sascha Hauer
2012-09-25 2:35 ` Jaehoon Chung
2012-09-25 6:15 ` Sascha Hauer
2012-09-25 7:28 ` Jaehoon Chung
2012-09-24 7:22 ` [PATCH 2/3] mmc: esdhc i.MX: Fix version register read Sascha Hauer
2012-09-25 6:41 ` Shawn Guo
2012-12-25 13:00 ` Shawn Guo
2012-09-24 7:22 ` [PATCH 3/3] mmc: esdhc i.MX: Support 8bit mode Sascha Hauer
2012-09-25 7:15 ` Shawn Guo
2012-09-25 7:27 ` Sascha Hauer
2012-09-25 7:33 ` Shawn Guo
2012-09-25 7:38 ` Sascha Hauer
2012-09-25 7:45 ` Shawn Guo
2012-09-25 8:05 ` Sascha Hauer
2012-09-25 8:50 ` Shawn Guo
2012-09-25 9:45 ` Sascha Hauer
2012-09-25 7:52 ` Chris Ball [this message]
2012-09-25 7:53 ` Shawn Guo
2012-09-25 8:00 ` Chris Ball
2012-12-26 2:56 ` Shawn Guo
2012-09-25 6:44 ` [PATCH] mmc: sdhci / i.MX esdhc buswidth patches Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k3vilety.fsf@pullcord.laptop.org \
--to=cjb@laptop.org \
--cc=eric@eukrea.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).