public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Manoj <manoj.iyer@canonical.com>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: SDHCI: Ricoh [1180:e823] unable to mount MMC cards.
Date: Thu, 31 Mar 2011 11:13:10 -0400	[thread overview]
Message-ID: <m3oc4rz5kp.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <4D949298.4000701@canonical.com> (Manoj's message of "Thu, 31 Mar 2011 09:41:28 -0500")

Hi,

On Thu, Mar 31 2011, Manoj wrote:
>> How about setting CONFIG_MMC_RICOH_MMC?
>
> Yes Sir... that was already set.
> CONFIG_MMC_RICOH_MMC=y

Ah, I think MMC_RICOH_MMC needs to know about this new PCI ID too.
I don't know whether that code knows how to turn off the MMC controller
on this model, though.

Please try this patch:

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index bd80f63..0852046 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2758,6 +2758,9 @@ static void ricoh_mmc_fixup_r5c832(struct pci_dev *dev)
 }
 DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_RICOH, PCI_DEVICE_ID_RICOH_R5C832, ricoh_mmc_fixup_r5c832);
 DECLARE_PCI_FIXUP_RESUME_EARLY(PCI_VENDOR_ID_RICOH, PCI_DEVICE_ID_RICOH_R5C832, ricoh_mmc_fixup_r5c832);
+
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_RICOH, PCI_DEVICE_ID_RICOH_R5C823, ricoh_mmc_fixup_r5c832);
+DECLARE_PCI_FIXUP_RESUME_EARLY(PCI_VENDOR_ID_RICOH, PCI_DEVICE_ID_RICOH_R5C823, ricoh_mmc_fixup_r5c832);
 #endif /*CONFIG_MMC_RICOH_MMC*/
 
 #if defined(CONFIG_DMAR) || defined(CONFIG_INTR_REMAP)
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 11fd381..9ec3316 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -1535,6 +1535,7 @@
 #define PCI_DEVICE_ID_RICOH_RL5C476	0x0476
 #define PCI_DEVICE_ID_RICOH_RL5C478	0x0478
 #define PCI_DEVICE_ID_RICOH_R5C822	0x0822
+#define PCI_DEVICE_ID_RICOH_R5C823	0x0823
 #define PCI_DEVICE_ID_RICOH_R5C832	0x0832
 #define PCI_DEVICE_ID_RICOH_R5C843	0x0843


and post dmesg of the result, as well as whether it worked.

We're trying the 0x832 disable method on an 0x823 controller, so I don't
know whether that'll work.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  reply	other threads:[~2011-03-31 15:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4D93AD5C.1070308@canonical.com>
2011-03-30 23:04 ` SDHCI: Ricoh [1180:e823] unable to mount MMC cards Chris Ball
2011-03-30 23:32   ` Manoj
2011-03-30 23:53     ` Chris Ball
2011-03-31 14:12       ` Manoj
2011-03-31 14:43         ` Chris Ball
2011-03-31 14:41           ` Manoj
2011-03-31 15:13             ` Chris Ball [this message]
2011-03-31 16:00               ` Manoj
2011-03-31 16:31                 ` Chris Ball
2011-03-31 17:09                   ` Manoj
2011-03-31 17:26                     ` Chris Ball
2011-03-31 17:59                       ` Manoj
2011-03-31 18:33                         ` Chris Ball
2011-03-31 18:47                           ` Philip Langdale
2011-03-31 14:47           ` Manoj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3oc4rz5kp.fsf@pullcord.laptop.org \
    --to=cjb@laptop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=manoj.iyer@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox