From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH 1/1] mmc: remove redundant irq disabling Date: Fri, 25 Mar 2011 09:22:57 -0400 Message-ID: References: <87zkoj7fiu.fsf@vostro.fn.ogness.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from void.printf.net ([89.145.121.20]:51094 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753013Ab1CYN03 (ORCPT ); Fri, 25 Mar 2011 09:26:29 -0400 In-Reply-To: <87zkoj7fiu.fsf@vostro.fn.ogness.net> (John Ogness's message of "Fri, 25 Mar 2011 09:47:37 +0100") Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: John Ogness Cc: Jens Axboe , linux-mmc@vger.kernel.org Hi John, On Fri, Mar 25 2011, John Ogness wrote: > From: John Ogness > > There is no need to disable irq's when using the sg_copy_*_buffer() > functions because those functions do that already. There are also > no races for the mm_queue struct here that would require the irq's > to be disabled before calling sg_copy_*_buffer(). > > Signed-off-by: John Ogness > --- > Patch against linux-next-20110324. > > drivers/mmc/card/queue.c | 8 -------- > 1 files changed, 0 insertions(+), 8 deletions(-) > > diff --git a/drivers/mmc/card/queue.c b/drivers/mmc/card/queue.c > index 2ae7275..c07322c 100644 > --- a/drivers/mmc/card/queue.c > +++ b/drivers/mmc/card/queue.c > @@ -343,18 +343,14 @@ unsigned int mmc_queue_map_sg(struct mmc_queue *mq) > */ > void mmc_queue_bounce_pre(struct mmc_queue *mq) > { > - unsigned long flags; > - > if (!mq->bounce_buf) > return; > > if (rq_data_dir(mq->req) != WRITE) > return; > > - local_irq_save(flags); > sg_copy_to_buffer(mq->bounce_sg, mq->bounce_sg_len, > mq->bounce_buf, mq->sg[0].length); > - local_irq_restore(flags); > } > > /* > @@ -363,17 +359,13 @@ void mmc_queue_bounce_pre(struct mmc_queue *mq) > */ > void mmc_queue_bounce_post(struct mmc_queue *mq) > { > - unsigned long flags; > - > if (!mq->bounce_buf) > return; > > if (rq_data_dir(mq->req) != READ) > return; > > - local_irq_save(flags); > sg_copy_from_buffer(mq->bounce_sg, mq->bounce_sg_len, > mq->bounce_buf, mq->sg[0].length); > - local_irq_restore(flags); > } Thanks, I'll push this to mmc-next for .40. - Chris. -- Chris Ball One Laptop Per Child