public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Sahitya Tummala <stummala@codeaurora.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	linux-mmc@vger.kernel.org, San Mehat <san@google.com>,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] msm_sdcc: remove needless cache flush after dma_unmap_sg()
Date: Mon, 28 Feb 2011 10:54:02 -0500	[thread overview]
Message-ID: <m3vd0417fp.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <1298896477.15439.9.camel@stummala-linux.in.qualcomm.com> (Sahitya Tummala's message of "Mon, 28 Feb 2011 18:04:37 +0530")

Hi,

On Mon, Feb 28 2011, Sahitya Tummala wrote:
>> > > dma_unmap_sg() already flushes the cache, I don't get what this
>> > > code is doing here.
>> > >
>> > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> > 
>> > Any feedback on this? I'd prefer the maintainer(s) Acked-by,
>> > but the patch is pretty clear as it stands I believe and I will
>> > request Chris to include it anyway, intuitively it is correct.
>> 
>> Hi Linus Walleij,
>> 
>> You are right. This patch looks good.

Thanks, merged to mmc-next for .39.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>
One Laptop Per Child

      reply	other threads:[~2011-02-28 15:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-16 22:28 [PATCH] msm_sdcc: remove needless cache flush after dma_unmap_sg() Linus Walleij
2011-02-26 12:01 ` Linus Walleij
2011-02-28 12:28   ` Sahitya Tummala
2011-02-28 12:34     ` Sahitya Tummala
2011-02-28 15:54       ` Chris Ball [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3vd0417fp.fsf@pullcord.laptop.org \
    --to=cjb@laptop.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=san@google.com \
    --cc=stummala@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox