[PATCH] msm_sdcc: remove needless cache flush after dma_unmap_sg()

[PATCH] msm_sdcc: remove needless cache flush after dma_unmap_sg()

[Linus Walleij]

dma_unmap_sg() already flushes the cache, I don't get what this
code is doing here.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/mmc/host/msm_sdcc.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c
index 153ab97..67b0881 100644
--- a/drivers/mmc/host/msm_sdcc.c
+++ b/drivers/mmc/host/msm_sdcc.c
@@ -266,14 +266,6 @@ msmsdcc_dma_complete_tlet(unsigned long data)
 	dma_unmap_sg(mmc_dev(host->mmc), host->dma.sg, host->dma.num_ents,
 		     host->dma.dir);
 
-	if (host->curr.user_pages) {
-		struct scatterlist *sg = host->dma.sg;
-		int i;
-
-		for (i = 0; i < host->dma.num_ents; i++)
-			flush_dcache_page(sg_page(sg++));
-	}
-
 	host->dma.sg = NULL;
 	host->dma.busy = 0;
 
-- 
1.7.4

Re: [PATCH] msm_sdcc: remove needless cache flush after dma_unmap_sg()

[Linus Walleij]

On Wed, Feb 16, 2011 at 11:28 PM, Linus Walleij
<linus.walleij@linaro.org> wrote:

> dma_unmap_sg() already flushes the cache, I don't get what this
> code is doing here.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Any feedback on this? I'd prefer the maintainer(s) Acked-by,
but the patch is pretty clear as it stands I believe and I will
request Chris to include it anyway, intuitively it is correct.

Yours,
Linus Walleij

Re: [PATCH] msm_sdcc: remove needless cache flush after dma_unmap_sg()

[Sahitya Tummala]

On Sat, 2011-02-26 at 13:01 +0100, Linus Walleij wrote:
> On Wed, Feb 16, 2011 at 11:28 PM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
> 
> > dma_unmap_sg() already flushes the cache, I don't get what this
> > code is doing here.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Any feedback on this? I'd prefer the maintainer(s) Acked-by,
> but the patch is pretty clear as it stands I believe and I will
> request Chris to include it anyway, intuitively it is correct.

Hi Linus Walleij,

You are right. This patch looks good.

-- 
Thanks,
Sahitya.
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum.

Re: [PATCH] msm_sdcc: remove needless cache flush after dma_unmap_sg()

[Sahitya Tummala]

Adding MSM list to the thread.

On Mon, 2011-02-28 at 17:58 +0530, Sahitya Tummala wrote:
> On Sat, 2011-02-26 at 13:01 +0100, Linus Walleij wrote:
> > On Wed, Feb 16, 2011 at 11:28 PM, Linus Walleij
> > <linus.walleij@linaro.org> wrote:
> > 
> > > dma_unmap_sg() already flushes the cache, I don't get what this
> > > code is doing here.
> > >
> > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > 
> > Any feedback on this? I'd prefer the maintainer(s) Acked-by,
> > but the patch is pretty clear as it stands I believe and I will
> > request Chris to include it anyway, intuitively it is correct.
> 
> Hi Linus Walleij,
> 
> You are right. This patch looks good.
> 
-- 
Thanks,
Sahitya.
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum.

Re: [PATCH] msm_sdcc: remove needless cache flush after dma_unmap_sg()

[Chris Ball]

Hi,

On Mon, Feb 28 2011, Sahitya Tummala wrote:
>> > > dma_unmap_sg() already flushes the cache, I don't get what this
>> > > code is doing here.
>> > >
>> > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> > 
>> > Any feedback on this? I'd prefer the maintainer(s) Acked-by,
>> > but the patch is pretty clear as it stands I believe and I will
>> > request Chris to include it anyway, intuitively it is correct.
>> 
>> Hi Linus Walleij,
>> 
>> You are right. This patch looks good.

Thanks, merged to mmc-next for .39.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>
One Laptop Per Child