From: Chris Ball <cjb@laptop.org>
To: Philip Rakity <prakity@marvell.com>
Cc: "Mok, Tze Siong" <tze.siong.mok@intel.com>,
Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>,
Takashi Iwai <tiwai@suse.de>,
Mark Brown <mark.brown314@gmail.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH V2] mmc: eMMC bus width may not work on all platforms
Date: Tue, 24 May 2011 00:42:52 -0400 [thread overview]
Message-ID: <m3wrhgaeur.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <15864FE4-25CB-46BC-ACC2-FC24C2E6E241@marvell.com> (Philip Rakity's message of "Sun, 22 May 2011 10:30:44 -0700")
Hi Philip,
On Sun, May 22 2011, Philip Rakity wrote:
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index baab027..6db91d6 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -174,14 +174,17 @@ static int mmc_decode_csd(struct mmc_card *card)
> }
>
> /*
> - * Read and decode extended CSD.
> + * Read extended CSD.
> */
> -static int mmc_read_ext_csd(struct mmc_card *card)
> +static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd)
This one doesn't work -- you're missing the half of the patch that hooks
up the rest of mmc.c to the new code, which was in v1. As-is, we get:
drivers/mmc/core/mmc.c: In function ‘mmc_init_card’:
drivers/mmc/core/mmc.c:621:3: error: too few arguments to function ‘mmc_read_ext_csd’
drivers/mmc/core/mmc.c:240:12: note: declared here
drivers/mmc/core/mmc.c: At top level:
drivers/mmc/core/mmc.c:404:12: warning: ‘mmc_compare_ext_csds’ defined but not used [-Wunused-function]
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-05-24 4:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 18:40 [PATCH] mmc: eMMC bus width may not work on all platforms Philip Rakity
2011-05-22 0:40 ` Mok, Tze Siong
2011-05-22 1:20 ` Chris Ball
2011-05-22 1:52 ` Philip Rakity
2011-05-22 17:30 ` [PATCH V2] " Philip Rakity
2011-05-24 4:42 ` Chris Ball [this message]
2011-05-25 1:14 ` Philip Rakity
2011-05-31 18:11 ` Philip Rakity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wrhgaeur.fsf@pullcord.laptop.org \
--to=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.brown314@gmail.com \
--cc=prakity@marvell.com \
--cc=tiwai@suse.de \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=tze.siong.mok@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox