From: zhangfei gao <zhangfei.gao@gmail.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: linux-mmc@vger.kernel.org,
Anton Vorontsov <avorontsov@ru.mvista.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: mmc: sdhci.h compile error
Date: Tue, 27 Apr 2010 14:54:03 +0800 [thread overview]
Message-ID: <q2h309424b61004262354heec04b53xc87e6c37046c6e77@mail.gmail.com> (raw)
In-Reply-To: <87k4rtzbjg.fsf@linux-g6p1.site>
[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]
Hi, Matt
On Tue, Apr 27, 2010 at 1:53 PM, Matt Fleming <matt@console-pimps.org> wrote:
> On Tue, 27 Apr 2010 11:45:28 +0800, zhangfei gao <zhangfei.gao@gmail.com> wrote:
>>
>> Fortunately, the typo does not impact the stability.
>> We found the typo when debugging our silicon issue, however, nothing
>> impove after the fix :)
>
> OK, thanks. In that case it probably doesn't need to go to -stable. You
> can add Reviewed-by: Matt Fleming <matt@console-pimps.org> to your
> patch.
>
Thanks for the review, patch is updated.
>From 1fbcb05dbab2e5e5de72060f0481a279fa3eda18 Mon Sep 17 00:00:00 2001
From: Zhangfei Gao <zgao6@marvell.com>
Date: Thu, 22 Apr 2010 11:25:17 +0800
Subject: [PATCH] mmc: SDHCI_INT_DATA_MASK typo error
Signed-off-by: Zhangfei Gao <zgao6@marvell.com>
Reviewed-by: Matt Fleming <matt@console-pimps.org>
---
drivers/mmc/host/sdhci.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index 842f46f..9ba4268 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -127,7 +127,7 @@
#define SDHCI_INT_DATA_MASK (SDHCI_INT_DATA_END | SDHCI_INT_DMA_END | \
SDHCI_INT_DATA_AVAIL | SDHCI_INT_SPACE_AVAIL | \
SDHCI_INT_DATA_TIMEOUT | SDHCI_INT_DATA_CRC | \
- SDHCI_INT_DATA_END_BIT | SDHCI_ADMA_ERROR)
+ SDHCI_INT_DATA_END_BIT | SDHCI_INT_ADMA_ERROR)
#define SDHCI_INT_ALL_MASK ((unsigned int)-1)
#define SDHCI_ACMD12_ERR 0x3C
--
1.6.0.4
[-- Attachment #2: 0001-mmc-SDHCI_INT_DATA_MASK-typo-error.patch --]
[-- Type: application/octet-stream, Size: 935 bytes --]
From 1fbcb05dbab2e5e5de72060f0481a279fa3eda18 Mon Sep 17 00:00:00 2001
From: Zhangfei Gao <zgao6@marvell.com>
Date: Thu, 22 Apr 2010 11:25:17 +0800
Subject: [PATCH] mmc: SDHCI_INT_DATA_MASK typo error
Signed-off-by: Zhangfei Gao <zgao6@marvell.com>
Reviewed-by: Matt Fleming <matt@console-pimps.org>
---
drivers/mmc/host/sdhci.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index 842f46f..9ba4268 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -127,7 +127,7 @@
#define SDHCI_INT_DATA_MASK (SDHCI_INT_DATA_END | SDHCI_INT_DMA_END | \
SDHCI_INT_DATA_AVAIL | SDHCI_INT_SPACE_AVAIL | \
SDHCI_INT_DATA_TIMEOUT | SDHCI_INT_DATA_CRC | \
- SDHCI_INT_DATA_END_BIT | SDHCI_ADMA_ERROR)
+ SDHCI_INT_DATA_END_BIT | SDHCI_INT_ADMA_ERROR)
#define SDHCI_INT_ALL_MASK ((unsigned int)-1)
#define SDHCI_ACMD12_ERR 0x3C
--
1.6.0.4
next prev parent reply other threads:[~2010-04-27 6:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 11:43 mmc: sdhci.h compile error zhangfei gao
2010-04-25 22:28 ` Matt Fleming
2010-04-26 7:46 ` zhangfei gao
2010-04-26 11:18 ` Matt Fleming
2010-04-27 3:45 ` zhangfei gao
2010-04-27 5:53 ` Matt Fleming
2010-04-27 6:54 ` zhangfei gao [this message]
2010-04-26 10:17 ` Anton Vorontsov
2010-04-29 22:28 ` Andrew Morton
2010-04-30 5:30 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=q2h309424b61004262354heec04b53xc87e6c37046c6e77@mail.gmail.com \
--to=zhangfei.gao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=linux-mmc@vger.kernel.org \
--cc=matt@console-pimps.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).