From: zhangfei gao <zhangfei.gao@gmail.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: linux-mmc@vger.kernel.org,
Anton Vorontsov <avorontsov@ru.mvista.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: mmc: sdhci.h compile error
Date: Tue, 27 Apr 2010 11:45:28 +0800 [thread overview]
Message-ID: <s2x309424b61004262045q2cf453bay7b2fa62571947e5a@mail.gmail.com> (raw)
In-Reply-To: <87mxwqzcl6.fsf@linux-g6p1.site>
Hi, Matt
On Mon, Apr 26, 2010 at 7:18 PM, Matt Fleming <matt@console-pimps.org> wrote:
> On Mon, 26 Apr 2010 15:46:31 +0800, zhangfei gao <zhangfei.gao@gmail.com> wrote:
>> Hi, Matt
>>
>> We also rename the function name to pass compile.
>> Besides, here is typo error drivers/mmc/host/sdhci.h, though it is not
>> a big deal.
>
> Good catch! How did you notice that? Did you see a failure at runtime or
> did you spot it by reading the code? If you were seeing a bug at runtime
> then this patch should also be sent to stable@kernel.org.
>
Fortunately, the typo does not impact the stability.
We found the typo when debugging our silicon issue, however, nothing
impove after the fix :)
> I don't have any hardware to test this patch but the change looks like
> it makes sense.
>
next prev parent reply other threads:[~2010-04-27 3:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 11:43 mmc: sdhci.h compile error zhangfei gao
2010-04-25 22:28 ` Matt Fleming
2010-04-26 7:46 ` zhangfei gao
2010-04-26 11:18 ` Matt Fleming
2010-04-27 3:45 ` zhangfei gao [this message]
2010-04-27 5:53 ` Matt Fleming
2010-04-27 6:54 ` zhangfei gao
2010-04-26 10:17 ` Anton Vorontsov
2010-04-29 22:28 ` Andrew Morton
2010-04-30 5:30 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s2x309424b61004262045q2cf453bay7b2fa62571947e5a@mail.gmail.com \
--to=zhangfei.gao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=linux-mmc@vger.kernel.org \
--cc=matt@console-pimps.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).