From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhangfei gao Subject: Re: mmc: sdhci.h compile error Date: Tue, 27 Apr 2010 11:45:28 +0800 Message-ID: References: <87zl0rb20u.fsf@linux-g6p1.site> <87mxwqzcl6.fsf@linux-g6p1.site> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-qy0-f179.google.com ([209.85.221.179]:38966 "EHLO mail-qy0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753289Ab0D0Dp3 (ORCPT ); Mon, 26 Apr 2010 23:45:29 -0400 Received: by qyk9 with SMTP id 9so18612110qyk.1 for ; Mon, 26 Apr 2010 20:45:28 -0700 (PDT) In-Reply-To: <87mxwqzcl6.fsf@linux-g6p1.site> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Matt Fleming Cc: linux-mmc@vger.kernel.org, Anton Vorontsov , Andrew Morton Hi, Matt On Mon, Apr 26, 2010 at 7:18 PM, Matt Fleming wrote: > On Mon, 26 Apr 2010 15:46:31 +0800, zhangfei gao wrote: >> Hi, Matt >> >> We also rename the function name to pass compile. >> Besides, here is typo error drivers/mmc/host/sdhci.h, though it is not >> a big deal. > > Good catch! How did you notice that? Did you see a failure at runtime or > did you spot it by reading the code? If you were seeing a bug at runtime > then this patch should also be sent to stable@kernel.org. > Fortunately, the typo does not impact the stability. We found the typo when debugging our silicon issue, however, nothing impove after the fix :) > I don't have any hardware to test this patch but the change looks like > it makes sense. >