From: Takashi Iwai <tiwai@suse.de>
To: Chris Ball <cjb@laptop.org>
Cc: Aries Lee <arieslee@jmicron.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: Fix a typo in ocr_avail mask check for MMC
Date: Fri, 17 Dec 2010 09:12:06 +0100 [thread overview]
Message-ID: <s5hwrn895t5.wl%tiwai@suse.de> (raw)
In-Reply-To: <20101216234511.GB17239@void.printf.net>
At Thu, 16 Dec 2010 23:45:11 +0000,
Chris Ball wrote:
>
> Hi Takashi,
>
> On Wed, Dec 15, 2010 at 02:19:22PM +0100, Takashi Iwai wrote:
> > In the patch "mmc: Add support for JMicron 388 SD/MMC controller",
> > I changed a wrong field for MMC during rewrite. Fixed now.
> >
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> > drivers/mmc/host/sdhci.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> > index 51f5209..be0ff14 100644
> > --- a/drivers/mmc/host/sdhci.c
> > +++ b/drivers/mmc/host/sdhci.c
> > @@ -1919,7 +1919,7 @@ int sdhci_add_host(struct sdhci_host *host)
> > mmc->ocr_avail_sd &= ~MMC_VDD_165_195;
> > mmc->ocr_avail_mmc = ocr_avail;
> > if (host->ocr_avail_mmc)
> > - mmc->ocr_avail_sd &= host->ocr_avail_mmc;
> > + mmc->ocr_avail_mmc &= host->ocr_avail_mmc;
> >
> > if (mmc->ocr_avail == 0) {
> > printk(KERN_ERR "%s: Hardware doesn't report any "
>
> Thanks, I've rebased this change into the original patch on my mmc-next
> branch.
OK, thanks!
Takashi
prev parent reply other threads:[~2010-12-17 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 13:19 [PATCH] mmc: Fix a typo in ocr_avail mask check for MMC Takashi Iwai
2010-12-16 23:45 ` Chris Ball
2010-12-17 8:12 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwrn895t5.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=arieslee@jmicron.com \
--cc=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox