From: "Michał Mirosław" <mirqus@gmail.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: linux-kernel@vger.kernel.org,
Alagu Sankar <alagusankar@embwise.com>,
Volker Ernst <volker.ernst@txtr.com>,
Dan Williams <dcbw@redhat.com>,
"John W. Linville" <linville@tuxdriver.com>,
Holger Schurig <hs4233@mail.mn-solutions.de>,
Bing Zhao <bzhao@marvell.com>,
libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH] libertas/sdio: set ECSI and SCSI bits for 1-bit transfers
Date: Wed, 31 Mar 2010 11:07:06 +0200 [thread overview]
Message-ID: <x2ve2d7436a1003310207t16a7d1d6r7853de2dfa647c6c@mail.gmail.com> (raw)
In-Reply-To: <1269970733-24681-1-git-send-email-daniel@caiaq.de>
2010/3/30 Daniel Mack <daniel@caiaq.de>:
[...]
> @@ -1022,6 +1025,27 @@ static int if_sdio_probe(struct sdio_func *func,
> if (ret)
> goto disable;
>
> + /* For 1-bit transfers, we need to enable the interrupt flags in
> + * the CCCR register. Temporarily set the function number to 0
> + * for that. */
> + if ((host->caps & MMC_CAP_SDIO_IRQ) &&
> + (host->ios.bus_width == MMC_BUS_WIDTH_1)) {
> + unsigned int num = func->num;
> + u8 reg;
> +
> + func->num = 0;
> + reg = sdio_readb(func, SDIO_CCCR_IF, &ret);
> + if (ret)
> + goto release_int;
> +
> + reg |= SDIO_BUS_ECSI | SDIO_BUS_SCSI;
> + sdio_writeb(func, reg, SDIO_CCCR_IF, &ret);
> + if (ret)
> + goto release_int;
> +
> + func->num = num;
> + }
> +
> card->ioport = sdio_readb(func, IF_SDIO_IOPORT, &ret);
> if (ret)
> goto release_int;
You should probably just use mmc_io_rw_direct() in this case instead
of abusing func->num.
Best Regards,
Michał Mirosław
next prev parent reply other threads:[~2010-03-31 9:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 17:38 [PATCH] libertas/sdio: set ECSI and SCSI bits for 1-bit transfers Daniel Mack
2010-03-30 18:37 ` Dan Williams
2010-03-30 18:40 ` Daniel Mack
2010-03-31 8:23 ` Alagu Sankar Vellaichamy
2010-03-31 13:34 ` Daniel Mack
2010-03-31 9:07 ` Michał Mirosław [this message]
[not found] ` <x2ve2d7436a1003310207t16a7d1d6r7853de2dfa647c6c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-03-31 9:08 ` Daniel Mack
2010-03-31 9:49 ` Michał Mirosław
2010-03-31 13:08 ` Daniel Mack
2010-03-31 13:31 ` [PATCH] libertas/sdio: set ECSI bit " Daniel Mack
2010-04-06 2:42 ` Dan Williams
2010-04-06 8:52 ` [PATCH] libertas/sdio: 8686: " Daniel Mack
2010-04-06 16:07 ` Dan Williams
2010-04-13 10:29 ` Daniel Mack
2010-04-13 13:06 ` John W. Linville
2010-04-13 13:21 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x2ve2d7436a1003310207t16a7d1d6r7853de2dfa647c6c@mail.gmail.com \
--to=mirqus@gmail.com \
--cc=alagusankar@embwise.com \
--cc=bzhao@marvell.com \
--cc=daniel@caiaq.de \
--cc=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=volker.ernst@txtr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).