From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Satya Tangirala <satyaprateek2357@gmail.com>,
dm-devel@redhat.com, linux-mmc@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v5 0/4] blk-crypto cleanups
Date: Tue, 12 Oct 2021 22:39:44 -0400 [thread overview]
Message-ID: <yq1h7dlps38.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20211012214330.40470-1-ebiggers@kernel.org> (Eric Biggers's message of "Tue, 12 Oct 2021 14:43:26 -0700")
Eric,
> This series renames struct blk_keyslot_manager to struct
> blk_crypto_profile, as it is misnamed; it doesn't always manage
> keyslots. It's much more logical to think of it as the "blk-crypto
> profile" of a device, similar to blk_integrity_profile.
Looks good to me, easier to follow.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2021-10-13 2:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 21:43 [PATCH v5 0/4] blk-crypto cleanups Eric Biggers
2021-10-12 21:43 ` [PATCH v5 1/4] blk-crypto-fallback: properly prefix function and struct names Eric Biggers
2021-10-12 21:43 ` [PATCH v5 2/4] blk-crypto: rename keyslot-manager files to blk-crypto-profile Eric Biggers
2021-10-12 21:43 ` [PATCH v5 3/4] blk-crypto: rename blk_keyslot_manager to blk_crypto_profile Eric Biggers
2021-10-12 21:43 ` [PATCH v5 4/4] blk-crypto: update inline encryption documentation Eric Biggers
2021-10-13 2:39 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1h7dlps38.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=ebiggers@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=satyaprateek2357@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox