From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Keith Busch <kbusch@kernel.org>,
Conrad Meyer <conradmeyer@meta.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: make secure erase and write zeroes ioctls interruptible as well
Date: Fri, 05 Jul 2024 00:03:41 -0400 [thread overview]
Message-ID: <yq1msmw8ozc.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20240701165219.1571322-1-hch@lst.de> (Christoph Hellwig's message of "Mon, 1 Jul 2024 18:51:10 +0200")
Christoph,
> Following discard in the last merge window, this series also makes
> secure erase and discard interruptible by fatal signals.
>
> The secure erase side is a straight port of the discard support.
> Unfortunately I don't have a way to test it, so I'm adding the eMMC
> maintainer as that is where the support originated so maybe they can
> give it a spin? (just do a blkdiscard -f -s /dev/<dev> and then
> Ctrl+C)
>
> The write zeroes support is a bit different as it is more complex due
> to the fallback code and there already is a helper taking flags that
> we piggy back on. This side has been extensively tested.
Looks good to me.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2024-07-05 4:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 16:51 make secure erase and write zeroes ioctls interruptible as well Christoph Hellwig
2024-07-01 16:51 ` [PATCH 01/10] block: move secure erase checks into the ioctl handler Christoph Hellwig
2024-07-01 16:51 ` [PATCH 02/10] block: factor out a bio_secure_erase_limit helper Christoph Hellwig
2024-07-01 16:51 ` [PATCH 03/10] block: add a blk_alloc_secure_erase_bio helper Christoph Hellwig
2024-07-01 16:51 ` [PATCH 04/10] blk-lib: check for kill signal in ioctl BLKSECDISCARD Christoph Hellwig
2024-07-01 16:51 ` [PATCH 05/10] block: factor out a blk_write_zeroes_limit helper Christoph Hellwig
2024-07-01 16:51 ` [PATCH 06/10] block: remove the LBA alignment check in __blkdev_issue_zeroout Christoph Hellwig
2024-07-01 16:51 ` [PATCH 07/10] block: move read-only and supported checks into (__)blkdev_issue_zeroout Christoph Hellwig
2024-07-01 16:51 ` [PATCH 08/10] block: refacto blkdev_issue_zeroout Christoph Hellwig
2024-07-01 16:51 ` [PATCH 09/10] block: limit the Write Zeroes to manually writing zeroes fallback Christoph Hellwig
2024-07-01 16:51 ` [PATCH 10/10] blk-lib: check for kill signal in ioctl BLKZEROOUT Christoph Hellwig
2024-07-05 4:03 ` Martin K. Petersen [this message]
2024-07-05 6:45 ` make secure erase and write zeroes ioctls interruptible as well Jens Axboe
2024-07-05 6:50 ` Christoph Hellwig
2024-07-05 7:03 ` Jens Axboe
2024-07-05 12:12 ` Christoph Hellwig
2024-07-05 6:53 ` (subset) " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1msmw8ozc.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=conradmeyer@meta.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox