From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCE742676E9 for ; Tue, 25 Feb 2025 10:22:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740478933; cv=none; b=qIet78zHNtuLGBqx+fC0zt8kFKRbhxjqO0qNvrUOJL+Qrk7mhb58KNLzbbRQfFEMp+l9TJEo2Xmn/yGvpZV+W/CPsHZr+Len2od8S3mSUGsi3FV4jAt8s/DXRBOqEHMX9LQBXCkZEVS8ZmVO0AGFwmhxP+pAJ2CTy0SQY+t9Rp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740478933; c=relaxed/simple; bh=7jS32IN9BvBO2WdCNC43qfDUQ12l0omi15BL6gdKjSA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Imjencbke05uTQM0GZZerl1DOpBaTPEUBf+oY5mzyFrAr1XIKVC2Lv9ylhKpWPY8RdY11XRSLZGb2iwTAcBxJj+v0NiX+icpf0mL/SPRjlujC8aJW5t8r7CESpBDhZZqjBNQvggQLOK9Zpq2Do74KUrW5QLaCe8JNesVir6hDjY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=BYmSE/vw; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="BYmSE/vw" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5e08064b4ddso7242397a12.1 for ; Tue, 25 Feb 2025 02:22:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1740478929; x=1741083729; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tirQLw4kKN2n7nJcTTMNgrKBrHBCr4gOSdhS88B+7TQ=; b=BYmSE/vwCQqhOVHnXgdu2OnPBHYSAN0tc0MAV0xqBuUsGDzq8lNT0fCAr2oLfrk1df ssJ+NPzNKFdg3DOfwx6mbmYp/hDrT4yxQC/2f1NXN+sR1jUL1Ri6eB9tvLpZUPIG9EtN TD8MVQSZG3KrJw0FEiwcJYw7pQgyJOFWhoYmGJtbdJw1kuwuJ5R50lwDirRMd34u/St+ lqbx2/K6XAaXn/+RsqQOYnirwuAhmae+df/oXjmdXBkQlDxrT9NBreqjZdKZFg58cyBS UdHYpYL+56yqXoraJv+i7epmRGp7AxfcexqKsSjtA5TRszKp2kfoC3McVOjyS4cK6RyF OSAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740478929; x=1741083729; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tirQLw4kKN2n7nJcTTMNgrKBrHBCr4gOSdhS88B+7TQ=; b=RXkrkIdglWpvgvmi1WLmuI/XTtgl9kCzGmkw0TjzFcSm0osejuFXzF30MxbzBAlpYm 7ztePGgTVX0B4EHUdVsaCwfMIARCC2NMpm+Wq7STQrS0KWwySQdiBvs5/537POTgokTR UD3646raXCe6o304bejn6PwxUp8KAp4dwhGUHD6xk1vSd0DNff9ALQmnxIP6bcGx16Zq ZncAIJlal0HZWRhd1N/uvmoNcbNSWyK3O0sG5+lSKtLl5jA2pxhHRgM6Wtc5EWxAagvH XfnG5S6RriMeSU7d7yzW0pw8p+DZezv00/kO9gZ3LOhXNtYMD+a9ab3spuhCaLt0md7A KCBQ== X-Forwarded-Encrypted: i=1; AJvYcCU7WICm2hRHUTNmig8DEzqBxG5AGyfN6r5lAjISknAgr537RNGKP+PkbFOanpldB8Q1TyzC2PVpNkplVDr9@vger.kernel.org X-Gm-Message-State: AOJu0Yx7C5B0wp7ZfGsPWHHI0Mto/TIHwHX1QwzT6VHyRO/gTz1DpPFC 1ueeQFefF7I9kIjcNC9Zoa+IWN8fKg8DapmYzfpoLegHwkQmz8bFtXo/wHD1zTA= X-Gm-Gg: ASbGncvgq4jBk2AmD484Q2T2hVvaw78uvC37Kf/1eSQIjrtFq74daVfZaEr4zNQkPdr iIbjZW20N0uJZs2ikzb8wJrDmQn7wAvzYNF5IhRILhWLsGR4T321EYJacDPqg76GKSCPO5WbMZ3 NRQUVMnUM11cFc70dmprNChGhF+4b2QPNK9XKkYtS0OCal/xi8mDI7hmI1n78ngAsiG1/CQkEQf 1u+FVZAGWaSblbxecmU8KEcBV+T/RqUnCaass5ru5/8Ze/K99z42YC/Bg7zutjMEBFCNtBhVWb5 56aU3zAojoX7b3zbgKPlC5ifUSCsNQ== X-Google-Smtp-Source: AGHT+IGt6pTVXx3wx/wRIHWsfSGAMt1cqb6es2jvkO8FnqdPuOZ02O/dkb0pjA9QIhd5xREqhWrTXg== X-Received: by 2002:a05:6402:e87:b0:5e0:82a0:50d7 with SMTP id 4fb4d7f45d1cf-5e0b70db116mr11539027a12.8.1740478929084; Tue, 25 Feb 2025 02:22:09 -0800 (PST) Received: from [10.100.51.161] ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e45a8b8c06sm1001139a12.22.2025.02.25.02.22.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Feb 2025 02:22:08 -0800 (PST) Message-ID: <0d9e596a-5316-4e00-862b-fd77552ae4b5@suse.com> Date: Tue, 25 Feb 2025 11:22:07 +0100 Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 0/6] rust: extend `module!` macro with integer parameter support To: Andreas Hindborg Cc: Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Trevor Gross , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Luis Chamberlain , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Adam Bratschi-Kaye , linux-kbuild@vger.kernel.org, Daniel Gomez , Simona Vetter , Greg KH , linux-modules@vger.kernel.org, Miguel Ojeda , Sami Tolvanen References: <20250218-module-params-v3-v7-0-5e1afabcac1b@kernel.org> <87ldtv1t1c.fsf@kernel.org> Content-Language: en-US From: Petr Pavlu In-Reply-To: <87ldtv1t1c.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/24/25 12:27, Andreas Hindborg wrote: > Hi Petr, > > "Andreas Hindborg" writes: > >> This series extends the `module!` macro with support module parameters. It >> also adds some string to integer parsing functions and updates `BStr` with >> a method to strip a string prefix. >> >> This series stated out as code by Adam Bratschi-Kaye lifted from the original >> `rust` branch [1]. >> >> After a bit of discussion on v3 about whether or not module parameters >> is a good idea, it seems that module parameters in Rust has a place >> in the kernel for now. This series is a dependency for `rnull`, the Rust >> null block driver [2]. > > > Luis told me you are the one wearing the modules hat for the moment. How > do you want to handle merging of patch 6 and subsequent maintenance of > the code? I'd say the easiest is for the entire series to go through the Rust tree. I'd also propose that any updates go primarily through that tree as well. > > I think we discussed you guys taking this under the current module > maintainer entry? If that is correct, will you add the new files to your > entry yourself, or should I include an update to MAINTAINERS in the next > version of this series? Makes sense, I think it is useful for all changes to this code to be looked at by both Rust and modules people. To that effect, we could add the following under the MODULES SUPPORT entry: F: rust/kernel/module_param.rs F: rust/macros/module.rs My slight worry is that this might suggest the entirety of maintenance is on the modules folks. Fortunately, adding the above and running get_maintainer.pl on rust/kernel/module_param.rs gives me a list of people for both Rust and modules, so this could be ok? -- Thanks, Petr