From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4178F2116F6 for ; Wed, 14 May 2025 08:38:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747211895; cv=none; b=gS4/6E9XaPfY/CeQFP2f2G2jqrZRa4TxhupDHWbOjfTDnUpT2z+FiR0pt6lA6vXQjW2VUkyba5YRx5T7/WlP7X1FhWaNW1j97DfZSA4WapgTdw30YKebgWO3FkuVqt/BeO3sC2a4cs2QqkpSFABgLrHKCbjZy1SgbcS20k9ikMk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747211895; c=relaxed/simple; bh=v3bAcO92mgzkH7OCDOt9w7M93EuoBxmV5z7loDAnBuE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uaIVkxVACAvTHO1DAIBvKdgBj11yf21Htn6H92fuKBy0ehRp9SCv/GDA9B8sf0s4LATzEBexJxWdO8oU+X8CqWNMNqFGRYEzfSRry908HC7rDDGTs6Gn8gXjzuoP1nqnuBwvKHoISiHu7pOf9H2bW2u4ZcTA5KsN+pZtbkE/ksY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=ZhkZAO55; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="ZhkZAO55" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3a0ebf39427so5391836f8f.3 for ; Wed, 14 May 2025 01:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1747211891; x=1747816691; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QuS3rpk01oe59tAY91l0mlGNbZV+w+wwZIkg9yAUzvM=; b=ZhkZAO55n0ryFMXrDFb5HKYgvgQrxFx08NgE0N9VgVSgn1fTXBJF49j7xxaxuvw0yR zmSxBFTZt5XBasUGK8+AiBC6RZjuFRJuMM7mhJOTRjyvWrP8qYYnrpWjv2Io9ZzZCYsv tyfvLjkIF6vH4DRrZQlKfivRVZ2Luxj1E91w8LboCLQ0XzJuUrk5rq/3DrIFsUiVa1xI 6x5mtZTL/bRt/ZpJTP0js+3qw5cDujZQJeB6nRJ+qZG1W9d9C27ngzJd2pN8h/TfcuxG EvmrmPhE+NBdQ2eUM1EoHpWNCof2ntx9+gHv4nBndQBjzbflpsafmVOPaL7t9vF91S0t sUXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747211891; x=1747816691; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QuS3rpk01oe59tAY91l0mlGNbZV+w+wwZIkg9yAUzvM=; b=vxaLC+2/374dVcDsy1Uq+HRdW4opYpzMGxG2TWVC9CmYQnKfQKeoD4hLQNh4z5C0JU 9Z12yeq7wHZ1Nez+kXpEcpI7g7XKgNdz/qwy6Tiz4Bj8kRsC330ILBcnagpKWt9iWtQJ Ne/nLx+vSHbF/W5aZEC2BRPCR4HPb4AhSDKd/MwCtRqxzKopzU1DhQMA5yolxBIFby5+ ezDHeYhN+y+51B9I4JHqz0prP+ZSERqxArl8VokHo2elK12FfUsbvgi6qilFylgSkXsg t0kfuZexIJXdxYMBB4Bc2Zqtz4TJGT58qmbViwYbmFK9x9eV6GvbzR9s5JEB/evgX5Jv mHJg== X-Forwarded-Encrypted: i=1; AJvYcCVy2eZbjp/h06ucEACyW34k/qzy9zaU7KYs385l0N8iEeUVeR0OJxaSqmoh0nIQZXMTlSgcQCjvVPDCFAaV@vger.kernel.org X-Gm-Message-State: AOJu0YzXut3Y2JzSrxthVjXxBBw1c8XRDc3FhCdYH/fBPNq4VzA48BBM OG0MMQ4/UGV/XoO0ZVGw1EJshWXtqcEqaCIMwnMyGqA4SI9Gmr8oLdad6HITD68= X-Gm-Gg: ASbGnctGrr3+C3Z31jT+CLuzckIc9T2zQ8tV9A9CM7Pibd4hNYWsgs6MwvaURCpKBWZ vjN8q/KyvAZ0MyXDeXkttuXhZFp5MdwbIJvXWMzugQE8Q7KdAxE0fqwLdoN2Uj6eQy+9O+73UfG MSIM++sP6ncpfR2h82w8xKZLyY5jNaXAkyW1yvpzvzYyhyazmK0xve3W5ARG1iPAtKABbIF3jRB 0sQguwoe4vLMkO6kY6ofNaqfkJ6qLH5ZP5CF5BAv3lZ8e2tXenThKBbsoUzRSdFKtrHYRGPu2ia fwCPamKhtcXUOZsxL+tEZG4EuNn4RoXnXTF3a5gcR9C+vdXrt3Yymg== X-Google-Smtp-Source: AGHT+IHyTzdduROE+Wg2w8XB61vo2bG33XhlahD4daZpMp6hYwmVe0Tbz/IVhZE17N/e//M2fErR6A== X-Received: by 2002:a5d:64c6:0:b0:3a0:b84c:52b4 with SMTP id ffacd0b85a97d-3a349695581mr2013629f8f.10.1747211891494; Wed, 14 May 2025 01:38:11 -0700 (PDT) Received: from [10.100.51.48] ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-4dea8580188sm8048020137.4.2025.05.14.01.38.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 May 2025 01:38:11 -0700 (PDT) Message-ID: <0dff052c-3857-4af3-a809-30ba124c4686@suse.com> Date: Wed, 14 May 2025 10:38:00 +0200 Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/5] module: Account for the build time module name mangling To: Peter Zijlstra Cc: mcgrof@kernel.org, x86@kernel.org, hpa@zytor.com, samitolvanen@google.com, da.gomez@samsung.com, masahiroy@kernel.org, nathan@kernel.org, nicolas@fjasle.eu, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-kbuild@vger.kernel.org, hch@infradead.org, gregkh@linuxfoundation.org, roypat@amazon.co.uk, Sean Christopherson References: <20250502141204.500293812@infradead.org> <20250502141844.263611823@infradead.org> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20250502141844.263611823@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/2/25 16:12, Peter Zijlstra wrote: > Sean noted that scripts/Makefile.lib:name-fix-token rule will mangle > the module name with s/-/_/g. > > Since this happens late in the build, only the kernel needs to bother > with this, the modpost tool still sees the original name. > > Reported-by: Sean Christopherson > Signed-off-by: Peter Zijlstra (Intel) > Tested-by: Sean Christopherson > --- > kernel/module/main.c | 26 +++++++++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > > --- a/kernel/module/main.c > +++ b/kernel/module/main.c > @@ -170,6 +170,30 @@ static inline void add_taint_module(stru > } > > /* > + * Like strncmp(), except s/-/_/g as per scripts/Makefile.lib:name-fix-token rule. > + */ > +static int mod_strncmp(const char *str_a, const char *str_b, size_t n) > +{ > + for (int i = 0; i < n; i++) { Nit: This could be 'size_t i' for consistency. I can adjust it when picking up the series. Reviewed-by: Petr Pavlu -- Petr > + char a = str_a[i]; > + char b = str_b[i]; > + int d; > + > + if (a == '-') a = '_'; > + if (b == '-') b = '_'; > + > + d = a - b; > + if (d) > + return d; > + > + if (!a) > + break; > + } > + > + return 0; > +} > + > +/* > [...]