From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 506544534B8 for ; Tue, 20 Jan 2026 16:11:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768925473; cv=none; b=BWzD9hQvllAF9RSEQhC/Dyj3KgiO7WCVu+fVmvh8OaNWHtdWPJL17sljDe8hNkQVN7eDNZmwGsr+A1b8Wclon/1LyzvHG2ZJA0eb9UgglERqYXdsjP1Du2o1RrGFuTsuTkMG7g4/QQXmKO/7g6sj1tXC/WyR47+jR9Ru4myEguA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768925473; c=relaxed/simple; bh=tWPMM5C6dDxijHPBafjYC1SjTJ0g6oQdXgKfFFqdrfE=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=su4tzUEQzXCgOu4hdlsb72uBzz3Lv4OWRGTtyokamjtdt833/NHXM9aVH26lldhDKxVFm3FfjZ6hREON9KGj6ALihKkId+K4u0RaJwjfBWV7qPpp2rK8Bv4YWJMYwMF6RSGs0C+dhGH/LR2vZhnkJ0lMytbg+sNI174boq6kRBU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CPQL1rBU; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CPQL1rBU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768925471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MRtTF5ndQZQPQCXaLyEtKnLXPyyjrq8Fu6UawbLrHgM=; b=CPQL1rBUyopq+ffKaGyKO2Qw5lxLo4F1eaqHzGAmUdzKIQQ/0mFAN//QxI6taP1u9k28xY uulmPnOxLjyLWAsjtPt8Sx1/KjaDAOXYvP70T0ra9CvNNcgUwlHXmXNMvYKKLfiGFzBYuv yyIQjXXfq+wWnX3C+HJIVsRguXV5NeM= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-1tkB6R5EMxK6yB4fnXnMgg-1; Tue, 20 Jan 2026 11:11:05 -0500 X-MC-Unique: 1tkB6R5EMxK6yB4fnXnMgg-1 X-Mimecast-MFC-AGG-ID: 1tkB6R5EMxK6yB4fnXnMgg_1768925463 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5C9A1195609F; Tue, 20 Jan 2026 16:11:03 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.2]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7E16C3000218; Tue, 20 Jan 2026 16:10:59 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20260115215100.312611-1-dhowells@redhat.com> <20260115215100.312611-3-dhowells@redhat.com> To: Ignat Korchagin Cc: dhowells@redhat.com, Lukas Wunner , Jarkko Sakkinen , Herbert Xu , Eric Biggers , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , "Jason A . Donenfeld" , Ard Biesheuvel , Stephan Mueller , linux-crypto@vger.kernel.org, keyrings@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v12 02/10] pkcs7: Allow the signing algo to calculate the digest itself Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1189034.1768925458.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Tue, 20 Jan 2026 16:10:58 +0000 Message-ID: <1189035.1768925458@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Ignat Korchagin wrote: > > + sig->digest =3D kmalloc(umax(sinfo->authattrs_= len, sig->digest_size), > > + GFP_KERNEL); > = > I'm still bothered by this "reallocation". You mentioned we need to do > some parsing for attributes, but it seems by the time this function is > called we have all the data to do something like > kmalloc(sig->algo_does_hash ? umax(sinfo->authattrs_len, > sig->digest_size) : sig->digest_size, GFP_KERNEL) during the initial > allocation. Or am I missing something? Actually, you're right, we do have that info at this point David