From: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Petr Pavlu <petr.pavlu@suse.com>,
Sami Tolvanen <samitolvanen@google.com>,
Daniel Gomez <da.gomez@samsung.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-modules@vger.kernel.org
Subject: [PATCH v2 0/2] tracing: Introduce relative stacktrace
Date: Sat, 1 Feb 2025 16:23:00 +0900 [thread overview]
Message-ID: <173839458022.2009498.14495253908367838065.stgit@devnote2> (raw)
Hi,
Here is the 2nd version of adding relative stacktrace for tracing.
The previous version is here;
https://lore.kernel.org/all/173807861687.1525539.15082309716909038251.stgit@mhiramat.roam.corp.google.com/
In this version, I changed the idea to only use the first 32bit of
the build_id of the modules instead of using live hash/id to identify
the module. Also, save the offset from the .text section for each
module instead of using the offset from the _stext for the module
address. (For the core kernel text address, keep using the offset
from _stext.)
This brings the following benefits:
- Do not need to save the live module allocation information on
somewhere in the reserved memory.
- Easy to find the module offline.
- We can ensure there are only offsets from the base, no KASLR info.
Moreover, encode/decode module build_id, we can show the module name
with the symbols on stacktrace.
Thus, this relative stacktrace is a better option for the persistent
ring buffer with security restricted environment (e.g. no kallsyms
access from user.)
# echo 1 > options/relative-stacktrace
# modprobe trace_events_sample
# echo stacktrace > events/sample-trace/foo_bar/trigger
# cat trace
event-sample-1622 [004] ...1. 397.542659: <stack trace>
=> event_triggers_post_call
=> trace_event_raw_event_foo_bar [trace_events_sample]
=> do_simple_thread_func [trace_events_sample]
=> simple_thread [trace_events_sample]
=> kthread
=> ret_from_fork
=> ret_from_fork_asm
Thank you,
---
Masami Hiramatsu (Google) (2):
modules: Add __module_build_id() to find module by build_id
tracing: Add relative-stacktrace option
include/linux/module.h | 8 +++++
include/linux/trace.h | 5 +++
kernel/module/Kconfig | 3 ++
kernel/module/kallsyms.c | 4 +--
kernel/module/main.c | 29 ++++++++++++++++++++
kernel/trace/Kconfig | 1 +
kernel/trace/trace.c | 50 ++++++++++++++++++++++++++++++----
kernel/trace/trace.h | 3 ++
kernel/trace/trace_entries.h | 18 ++++++++++++
kernel/trace/trace_output.c | 62 ++++++++++++++++++++++++++++++++++++++++++
lib/Kconfig.debug | 1 +
11 files changed, 175 insertions(+), 9 deletions(-)
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next reply other threads:[~2025-02-01 7:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-01 7:23 Masami Hiramatsu (Google) [this message]
2025-02-01 7:23 ` [PATCH v2 1/2] modules: Add __module_build_id() to find module by build_id Masami Hiramatsu (Google)
2025-02-01 7:23 ` [PATCH v2 2/2] tracing: Add relative-stacktrace option Masami Hiramatsu (Google)
2025-02-03 15:32 ` [PATCH v2 0/2] tracing: Introduce relative stacktrace Steven Rostedt
2025-02-05 12:25 ` Masami Hiramatsu
2025-02-05 13:28 ` Masami Hiramatsu
2025-02-05 14:53 ` Steven Rostedt
2025-02-05 22:52 ` Steven Rostedt
2025-02-06 0:28 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173839458022.2009498.14495253908367838065.stgit@devnote2 \
--to=mhiramat@kernel.org \
--cc=da.gomez@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).