From: Petr Pavlu <petr.pavlu@suse.com>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Daniel Gomez <da.gomez@kernel.org>,
Aaron Tomlin <atomlin@atomlin.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] module: Remove unused DISCARD_EH_FRAME definition from module.lds.S
Date: Thu, 9 Jul 2026 10:49:52 +0200 [thread overview]
Message-ID: <19204b0b-8c42-4df2-92a7-26af32e15d50@suse.com> (raw)
In-Reply-To: <CABCJKueO3NkVrsR9H6JxFpEf=UsGZ2PCPSrs6hXJh+cdBjikVg@mail.gmail.com>
On 6/17/26 9:29 PM, Sami Tolvanen wrote:
> On Fri, Jun 12, 2026 at 6:40 AM Petr Pavlu <petr.pavlu@suse.com> wrote:
>>
>> The linker script scripts/module.lds.S contains an unused DISCARD_EH_FRAME
>> definition introduced by commit 68c76ad4a957 ("arm64: unwind: add
>> asynchronous unwind tables to kernel and modules").
>>
>> As shown in an earlier version of that patch [1], DISCARD_EH_FRAME was
>> meant to be used by SANITIZER_DISCARDS in the same file, as follows:
>>
>> -# define SANITIZER_DISCARDS *(.eh_frame)
>> +# define SANITIZER_DISCARDS DISCARD_EH_FRAME
>>
>> However, in the meantime, SANITIZER_DISCARDS was removed entirely from
>> module.lds.S by commit 89245600941e ("cfi: Switch to -fsanitize=kcfi").
>> Eventually, the mentioned commit 68c76ad4a957 only added the new
>> DISCARD_EH_FRAME definition to this file without actually using it.
>>
>> The file include/asm-generic/vmlinux.lds.h contains a similar
>> DISCARD_EH_FRAME definition for vmlinux to discard .eh_frame sections that
>> may be present when CONFIG_GCOV_KERNEL, CONFIG_KASAN_GENERIC or
>> CONFIG_KCSAN is enabled. Testing these options on arm64 with LLVM 19.1 did
>> not show any unexpected .eh_frame sections in modules.
>>
>> Remove the unused DISCARD_EH_FRAME definition from scripts/module.lds.S.
>>
>> Link: https://lore.kernel.org/linux-arm-kernel/20220701152724.3343599-2-ardb@kernel.org/ [1]
>> Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
>
> Reviewed-by: Sami Tolvanen <samitolvanen@google.com>
Thanks, queued on modules-next for v7.3-rc1.
-- Petr
prev parent reply other threads:[~2026-07-09 8:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 13:38 [PATCH] module: Remove unused DISCARD_EH_FRAME definition from module.lds.S Petr Pavlu
2026-06-17 19:29 ` Sami Tolvanen
2026-07-09 8:49 ` Petr Pavlu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19204b0b-8c42-4df2-92a7-26af32e15d50@suse.com \
--to=petr.pavlu@suse.com \
--cc=ardb@kernel.org \
--cc=atomlin@atomlin.com \
--cc=da.gomez@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox