From: Michal Marek <mmarek@suse.cz>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Cong Wang <amwang@redhat.com>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org
Subject: Re: [PATCH] kbuild: do not check for ancient modutils tools
Date: Mon, 23 Jan 2012 15:17:10 +0100 [thread overview]
Message-ID: <20120123141710.GA26809@sepie.suse.cz> (raw)
In-Reply-To: <CAPXgP12vChg=820uamRa6dTekEQD_xa6mg-nroOm1br+7-JCqw@mail.gmail.com>
On Fri, Jan 20, 2012 at 05:40:58PM +0100, Kay Sievers wrote:
> On Wed, Jan 18, 2012 at 05:33, Cong Wang <amwang@redhat.com> wrote:
> > On Tue, 2012-01-17 at 14:50 -0200, Lucas De Marchi wrote:
> >> scripts/depmod.sh checks for the output of '-V' expecting that it has
> >> module-init-tools in it. It's a hack to prevent users from using
> >> modutils instead of module-init-tools, that only works with 2.4.x
> >> kernels. This however prints an annoying warning for kmod tool, that is
> >> currently replacing module-init-tools.
You could call kmod "module-init-tools 3.13 (compatible; kmod 3)" ;)
Just kidding.
> >> Rather than putting another check for kmod's version, just remove it
> >> since users of 2.4.x kernel are unlikely to upgrade to 3.x, and if they
> >> do, let depmod fail in that case because they should know what they are
> >> doing.
> >>
> >> Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
> >
> > Acked-by: WANG Cong <amwang@redhat.com>
>
> Michal, mind picking this up? The warning it produces with kmod is
> really misleading, and the check seems unnecessary these days.
I applied it to kbuild.git#rc-fixes and will send it to Linus for 3.3.
Michal
next prev parent reply other threads:[~2012-01-23 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 16:50 [PATCH] kbuild: do not check for ancient modutils tools Lucas De Marchi
2012-01-18 4:33 ` Cong Wang
2012-01-20 16:40 ` Kay Sievers
2012-01-23 14:17 ` Michal Marek [this message]
2012-01-23 14:32 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120123141710.GA26809@sepie.suse.cz \
--to=mmarek@suse.cz \
--cc=amwang@redhat.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).