* Bug#782692: kmod: spurious spaces in lsmod output
@ 2015-04-16 10:56 Marco d'Itri
2015-04-16 11:48 ` Lucas De Marchi
0 siblings, 1 reply; 2+ messages in thread
From: Marco d'Itri @ 2015-04-16 10:56 UTC (permalink / raw)
To: linux-modules
----- Forwarded message from Santiago Vila <sanvila@unex.es> -----
From: Santiago Vila <sanvila@unex.es>
To: submit@bugs.debian.org
Subject: Bug#782692: kmod: spurious spaces in lsmod output
Package: kmod
Version: 18-3
Severity: minor
While using "localyesconfig" to build a custom kernel I noticed that lsmod
output now has trailing spaces when the list of "Used by" modules is empty.
The following (untested but trivial) patch should fix it. It just delays
the space to the point where we are sure that there are more things to print.
Thanks.
diff --git a/tools/lsmod.c b/tools/lsmod.c
index e953c7e..c1bab7f 100644
--- a/tools/lsmod.c
+++ b/tools/lsmod.c
@@ -64,15 +64,17 @@ static int do_lsmod(int argc, char *argv[])
struct kmod_list *holders, *hitr;
int first = 1;
- printf("%-19s %8ld %d ", name, size, use_count);
+ printf("%-19s %8ld %d", name, size, use_count);
holders = kmod_module_get_holders(mod);
kmod_list_foreach(hitr, holders) {
struct kmod_module *hm = kmod_module_get_module(hitr);
if (!first)
putchar(',');
- else
+ else {
+ putchar(' ');
first = 0;
+ }
fputs(kmod_module_get_name(hm), stdout);
kmod_module_unref(hm);
----- End forwarded message -----
--
ciao,
Marco
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Bug#782692: kmod: spurious spaces in lsmod output
2015-04-16 10:56 Bug#782692: kmod: spurious spaces in lsmod output Marco d'Itri
@ 2015-04-16 11:48 ` Lucas De Marchi
0 siblings, 0 replies; 2+ messages in thread
From: Lucas De Marchi @ 2015-04-16 11:48 UTC (permalink / raw)
To: linux-modules
On Thu, Apr 16, 2015 at 7:56 AM, Marco d'Itri <md@linux.it> wrote:
> ----- Forwarded message from Santiago Vila <sanvila@unex.es> -----
>
> From: Santiago Vila <sanvila@unex.es>
> To: submit@bugs.debian.org
> Subject: Bug#782692: kmod: spurious spaces in lsmod output
>
> Package: kmod
> Version: 18-3
> Severity: minor
>
> While using "localyesconfig" to build a custom kernel I noticed that lsmod
> output now has trailing spaces when the list of "Used by" modules is empty.
>
> The following (untested but trivial) patch should fix it. It just delays
> the space to the point where we are sure that there are more things to print.
Applied, thanks.
--
Lucas De Marchi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-16 11:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-16 10:56 Bug#782692: kmod: spurious spaces in lsmod output Marco d'Itri
2015-04-16 11:48 ` Lucas De Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).