From: Greg KH <gregkh@linuxfoundation.org>
To: Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: Jessica Yu <jeyu@kernel.org>,
Alexey Gladkov <gladkov.alexey@gmail.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
linux-api@vger.kernel.org,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>,
"Dmitry V. Levin" <ldv@altlinux.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-modules <linux-modules@vger.kernel.org>
Subject: Re: [RESEND PATCH v1] moduleparam: Save information about built-in modules in separate file
Date: Thu, 28 Mar 2019 19:45:46 +0100 [thread overview]
Message-ID: <20190328184546.GB23800@kroah.com> (raw)
In-Reply-To: <CAKi4VA+14kihzGFbMT623BwMbZEzgYU6+jz8MpR9jqoC059oog@mail.gmail.com>
On Thu, Mar 28, 2019 at 10:41:59AM -0700, Lucas De Marchi wrote:
> On Wed, Mar 27, 2019 at 8:40 AM Jessica Yu <jeyu@kernel.org> wrote:
> > >No. There are definitely not all modules. I have a builtin sha256_generic,
> > >but I can't find him in the /sys/module.
> >
> > Yeah, you'll only find builtin modules under /sys/module/ if it has any module
> > parameters, otherwise you won't find it there. As Masahiro already mentioned,
> > if a builtin module has any parameters, they would be accessible under /sys/module/.
>
> Could we please change that and add the sysfs entry regardless of
> what's being discussed here? Not having the entry there simply because
> we don't have parameters for that module always annoyed me.
What is the sysfs directory going to show? Will it just be empty?
Feel free to send a patch for this, but from what I remember, it wasn't
the easiest thing to do for some reason. But given that the code was
implemented before git was, I can't quite remember.
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-28 18:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190315101013.GN8455@Legion-PC.fortress>
[not found] ` <CAK7LNATsm23e_CuyfFw7_CR8xZQ3HnwNHCXhEm_zQZU2PUGK5A@mail.gmail.com>
[not found] ` <20190326172411.GA15936@Legion-PC.fortress>
[not found] ` <20190327154025.GB23293@linux-8ccs>
2019-03-28 17:41 ` [RESEND PATCH v1] moduleparam: Save information about built-in modules in separate file Lucas De Marchi
2019-03-28 18:45 ` Greg KH [this message]
2019-03-28 21:33 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328184546.GB23800@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gladkov.alexey@gmail.com \
--cc=glebfm@altlinux.org \
--cc=jeyu@kernel.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=ldv@altlinux.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=michal.lkml@markovi.net \
--cc=rusty@rustcorp.com.au \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).