From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=2Kvf=YE=vger.kernel.org=linux-modules-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,
	SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A0625C47404
	for <linux-modules@archiver.kernel.org>; Fri, 11 Oct 2019 15:33:26 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 7136C2089F
	for <linux-modules@archiver.kernel.org>; Fri, 11 Oct 2019 15:33:26 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1570808006;
	bh=NQZN68RxCKcJkzW1s3gFdeTrbhdEj1wIh0TR9/+K+qM=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From;
	b=p3H0jQRO2i25JB3fJXng4c/4LRq7bVJ7f084lYfv8fcZICFiTqLitImj0UYSFTyo/
	 LgHpZL9nB+JzUm8bvFvDOzMXOeWr11PEcbtFs9swHeBuVNma1gBeqQxN5ngMH8e0Ji
	 o5ZRSTaEUPXPOOVPIiZp+pYVMKi0rLzoW7tFyW1s=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727453AbfJKPdX (ORCPT
        <rfc822;linux-modules@archiver.kernel.org>);
        Fri, 11 Oct 2019 11:33:23 -0400
Received: from mail.kernel.org ([198.145.29.99]:55882 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726705AbfJKPdW (ORCPT <rfc822;linux-modules@vger.kernel.org>);
        Fri, 11 Oct 2019 11:33:22 -0400
Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id D4820206A1;
        Fri, 11 Oct 2019 15:33:21 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1570808002;
        bh=NQZN68RxCKcJkzW1s3gFdeTrbhdEj1wIh0TR9/+K+qM=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=Tz03FhijMzybaUjcRLnyARmWhnjL4zawrMNjqenOQ2brweq6ww9pf0P/lwIVNZFwK
         L4HMwQSvOgVfANpq/ZXodjDiuq6PgVAiOWONjFL9iFfBk0h1hNWvN7O0zVWT+xPV+O
         hRpkxIf65rIB2WhICnqeOGNjdDFUtpuehZ42Boqw=
Date:   Fri, 11 Oct 2019 17:33:19 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Matthias Maennich <maennich@google.com>
Cc:     linux-kernel@vger.kernel.org, kernel-team@android.com,
        Jessica Yu <jeyu@kernel.org>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Martijn Coenen <maco@android.com>,
        Lucas De Marchi <lucas.de.marchi@gmail.com>,
        Shaun Ruffell <sruffell@sruffell.net>,
        Will Deacon <will@kernel.org>, linux-kbuild@vger.kernel.org,
        linux-modules@vger.kernel.org
Subject: Re: [PATCH 2/4] modpost: make updating the symbol namespace explict
Message-ID: <20191011153319.GC1283883@kroah.com>
References: <20191010151443.7399-1-maennich@google.com>
 <20191010151443.7399-3-maennich@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191010151443.7399-3-maennich@google.com>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: owner-linux-modules@vger.kernel.org
Precedence: bulk
List-ID: <linux-modules.vger.kernel.org>

On Thu, Oct 10, 2019 at 04:14:41PM +0100, Matthias Maennich wrote:
> Setting the symbol namespace of a symbol within sym_add_exported feels
> displaced and lead to issues in the current implementation of symbol
> namespaces. This patch makes updating the namespace an explicit call to
> decouple it from adding a symbol to the export list.
> 
> Signed-off-by: Matthias Maennich <maennich@google.com>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>