From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0E9CC47404 for ; Fri, 11 Oct 2019 15:34:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB42721D7F for ; Fri, 11 Oct 2019 15:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570808043; bh=mEEKusn2KXkFF2wpevGWXBDSbPnxXtY0JLt93wPjI5c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=txHJo089zsQDgkQBh1aaEtXhmOl4JtzoXIbWJ/25qd48mom0pyi0gejQtRO55fuxw Wb2y0rplb7/VSDKfgRwtq+oWjBrsslVEiohNyz0AB6+V2XA3bN0YOKlxf1Vhc1ZzGt iYDUTqxeFeg1R7CfqkYx2Fxm44yEZM9SrcGAQ+/0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727721AbfJKPeA (ORCPT ); Fri, 11 Oct 2019 11:34:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:56112 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726692AbfJKPeA (ORCPT ); Fri, 11 Oct 2019 11:34:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 67B47206A1; Fri, 11 Oct 2019 15:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570808039; bh=mEEKusn2KXkFF2wpevGWXBDSbPnxXtY0JLt93wPjI5c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RKONM7n3ew0qj8uo7JgnNFWZRsUqkmylNmRCXgoTgcf18TV7jJh6yuRuu8JEfGYD8 +xoems0f8jS4JOqNQ1ILV/qY5p7eHZN2m9PiKeY8ZXcfmDl4hUQpAKaJQRQwP/DDVW mkD/k/SxyRaWUdsxpSUKezKqljOQjcDvcqKvAsq4= Date: Fri, 11 Oct 2019 17:33:57 +0200 From: Greg Kroah-Hartman To: Matthias Maennich Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Jessica Yu , Masahiro Yamada , Martijn Coenen , Lucas De Marchi , Shaun Ruffell , Will Deacon , linux-kbuild@vger.kernel.org, linux-modules@vger.kernel.org Subject: Re: [PATCH 3/4] symbol namespaces: revert to previous __ksymtab name scheme Message-ID: <20191011153357.GD1283883@kroah.com> References: <20191010151443.7399-1-maennich@google.com> <20191010151443.7399-4-maennich@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191010151443.7399-4-maennich@google.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: owner-linux-modules@vger.kernel.org Precedence: bulk List-ID: On Thu, Oct 10, 2019 at 04:14:42PM +0100, Matthias Maennich wrote: > The introduction Symbol Namespaces changed the naming schema of the > __ksymtab entries from __kysmtab__symbol to __ksymtab_NAMESPACE.symbol. > > That caused some breakages in tools that depend on the name layout in > either the binaries(vmlinux,*.ko) or in System.map. E.g. kmod's depmod > would not be able to read System.map without a patch to support symbol > namespaces. A warning reported by depmod for namespaced symbols would > look like > > depmod: WARNING: [...]/uas.ko needs unknown symbol usb_stor_adjust_quirks > > In order to address this issue, revert to the original naming scheme and > rather read the __kstrtabns_ entries and their corresponding > values from __ksymtab_strings to update the namespace values for > symbols. After having read all symbols and handled them in > handle_modversions(), the symbols are created. In a second pass, read > the __kstrtabns_ entries and update the namespaces accordingly. > > Suggested-by: Jessica Yu > Fixes: 8651ec01daed ("module: add support for symbol namespaces.") > Signed-off-by: Matthias Maennich Reviewed-by: Greg Kroah-Hartman