From: Kees Cook <keescook@chromium.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Jessica Yu <jeyu@kernel.org>,
linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org
Subject: Re: [PATCH] module: add in-kernel support for decompressing
Date: Thu, 2 Dec 2021 00:14:18 -0800 [thread overview]
Message-ID: <202112020012.8B4C205@keescook> (raw)
In-Reply-To: <YafYvA5JWMgb6PVy@google.com>
On Wed, Dec 01, 2021 at 12:19:08PM -0800, Dmitry Torokhov wrote:
> On Wed, Dec 01, 2021 at 11:24:35AM -0800, Kees Cook wrote:
> > On Sat, Nov 27, 2021 at 09:48:22PM -0800, Dmitry Torokhov wrote:
> > > /* Flags for sys_finit_module: */
> > > #define MODULE_INIT_IGNORE_MODVERSIONS 1
> > > #define MODULE_INIT_IGNORE_VERMAGIC 2
> > > +#define MODULE_INIT_COMPRESSED_DATA 4
> >
> > bikeshedding: adding "_DATA" seems redundant/misleading? The entire
> > module is compressed, so maybe call it just MODULE_INIT_COMPRESSED ?
>
> OK, or maybe MODULE_INIT_COMPRESSED_FILE since we are indeed dealing
> with a file?
Sounds good to me! :)
As far as my tangent on using the crypto subsystem, I think that looks
like a long path, so your existing routines are likely the right place
to start. I still wonder if it might be able to use of the "acomp" API
instead of calling directly into the specific decompressor.
--
Kees Cook
next prev parent reply other threads:[~2021-12-02 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-28 5:48 [PATCH] module: add in-kernel support for decompressing Dmitry Torokhov
2021-12-01 19:24 ` Kees Cook
2021-12-01 20:19 ` Dmitry Torokhov
2021-12-02 8:14 ` Kees Cook [this message]
2021-12-03 1:01 ` Luis Chamberlain
2021-12-03 21:06 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112020012.8B4C205@keescook \
--to=keescook@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).