From: Aaron Tomlin <atomlin@redhat.com>
To: mcgrof@kernel.org, christophe.leroy@csgroup.eu,
daniel.thompson@linaro.org, hch@infradead.org
Cc: cl@linux.com, mbenes@suse.cz, akpm@linux-foundation.org,
jeyu@kernel.org, linux-kernel@vger.kernel.org,
linux-modules@vger.kernel.org, void@manifault.com,
atomlin@atomlin.com, allen.lkml@gmail.com, joe@perches.com,
msuchanek@suse.de, oleksandr@natalenko.name,
jason.wessel@windriver.com, pmladek@suse.com
Subject: [PATCH] kdb: Remove redundant module related references
Date: Tue, 8 Mar 2022 10:52:03 +0000 [thread overview]
Message-ID: <20220308105203.2981099-1-atomlin@redhat.com> (raw)
In-Reply-To: <20220307174741.2889588-1-atomlin@redhat.com>
Hi Luis, Christoph, Daniel,
Is this patch ok or would you rather another iteration of the series?
Either way is fine for me. Thanks.
No functional change.
There is no need to include linux/module.h.
This patch addresses the above. Furthermore, we remove the list of known
loaded modules i.e. stored in 'kdb_modules', since it is now redundant.
Fixes: 260681b3763f ("module: Move kdb module related code out of main kdb code")
Signed-off-by: Aaron Tomlin <atomlin@redhat.com>
---
kernel/debug/kdb/kdb_io.c | 1 -
kernel/debug/kdb/kdb_keyboard.c | 1 -
kernel/debug/kdb/kdb_private.h | 4 ----
kernel/debug/kdb/kdb_support.c | 1 -
4 files changed, 7 deletions(-)
diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
index 6735ac36b718..67d3c48a1522 100644
--- a/kernel/debug/kdb/kdb_io.c
+++ b/kernel/debug/kdb/kdb_io.c
@@ -9,7 +9,6 @@
* Copyright (c) 2009 Wind River Systems, Inc. All Rights Reserved.
*/
-#include <linux/module.h>
#include <linux/types.h>
#include <linux/ctype.h>
#include <linux/kernel.h>
diff --git a/kernel/debug/kdb/kdb_keyboard.c b/kernel/debug/kdb/kdb_keyboard.c
index f877a0a0d7cf..f87c750d3eb3 100644
--- a/kernel/debug/kdb/kdb_keyboard.c
+++ b/kernel/debug/kdb/kdb_keyboard.c
@@ -11,7 +11,6 @@
#include <linux/kdb.h>
#include <linux/keyboard.h>
#include <linux/ctype.h>
-#include <linux/module.h>
#include <linux/io.h>
/* Keyboard Controller Registers on normal PCs. */
diff --git a/kernel/debug/kdb/kdb_private.h b/kernel/debug/kdb/kdb_private.h
index 0d2f9feea0a4..1f8c519a5f81 100644
--- a/kernel/debug/kdb/kdb_private.h
+++ b/kernel/debug/kdb/kdb_private.h
@@ -226,10 +226,6 @@ extern void kdb_kbd_cleanup_state(void);
#define kdb_kbd_cleanup_state()
#endif /* ! CONFIG_KDB_KEYBOARD */
-#ifdef CONFIG_MODULES
-extern struct list_head *kdb_modules;
-#endif /* CONFIG_MODULES */
-
extern char kdb_prompt_str[];
#define KDB_WORD_SIZE ((int)sizeof(unsigned long))
diff --git a/kernel/debug/kdb/kdb_support.c b/kernel/debug/kdb/kdb_support.c
index df2bface866e..08229ffb6b5e 100644
--- a/kernel/debug/kdb/kdb_support.c
+++ b/kernel/debug/kdb/kdb_support.c
@@ -17,7 +17,6 @@
#include <linux/stddef.h>
#include <linux/vmalloc.h>
#include <linux/ptrace.h>
-#include <linux/module.h>
#include <linux/highmem.h>
#include <linux/hardirq.h>
#include <linux/delay.h>
--
2.34.1
next prev parent reply other threads:[~2022-03-08 10:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 17:44 [PATCH v10 00/14] module: core code clean up Aaron Tomlin
2022-03-07 17:44 ` [PATCH v10 01/14] module: Move all into module/ Aaron Tomlin
2022-03-07 17:44 ` [PATCH v10 02/14] module: Simple refactor in preparation for split Aaron Tomlin
2022-03-07 17:44 ` [PATCH v10 03/14] module: Make internal.h and decompress.c more compliant Aaron Tomlin
2022-03-07 17:44 ` [PATCH v10 04/14] module: Move livepatch support to a separate file Aaron Tomlin
2022-03-07 17:45 ` [PATCH v10 05/14] module: Move latched RB-tree " Aaron Tomlin
2022-03-07 17:45 ` [PATCH v10 06/14] module: Move strict rwx " Aaron Tomlin
2022-03-07 17:45 ` [PATCH v10 07/14] module: Move extra signature support out of core code Aaron Tomlin
2022-03-07 17:45 ` [PATCH v10 08/14] module: Move kmemleak support to a separate file Aaron Tomlin
2022-03-07 17:45 ` [PATCH v10 09/14] module: Move kallsyms support into " Aaron Tomlin
2022-03-07 17:45 ` [PATCH v10 10/14] module: kallsyms: Fix suspicious rcu usage Aaron Tomlin
2022-03-07 17:45 ` [PATCH v10 11/14] module: Move procfs support into a separate file Aaron Tomlin
2022-03-07 17:47 ` [PATCH v10 12/14] module: Move sysfs " Aaron Tomlin
2022-03-07 17:47 ` [PATCH v10 13/14] module: Move kdb module related code out of main kdb code Aaron Tomlin
2022-03-08 8:36 ` Christophe Leroy
2022-03-08 10:51 ` Aaron Tomlin
2022-03-08 10:52 ` Aaron Tomlin [this message]
2022-03-09 12:06 ` [PATCH] kdb: Remove redundant module related references Daniel Thompson
2022-03-10 9:20 ` Aaron Tomlin
2022-03-10 21:07 ` Luis Chamberlain
2022-03-11 15:47 ` Daniel Thompson
2022-03-11 16:01 ` Aaron Tomlin
2022-03-11 16:19 ` Daniel Thompson
2022-03-07 17:47 ` [PATCH v10 14/14] module: Move version support into a separate file Aaron Tomlin
2022-03-07 21:05 ` [PATCH v10 00/14] module: core code clean up Luis Chamberlain
2022-03-08 6:10 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220308105203.2981099-1-atomlin@redhat.com \
--to=atomlin@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=allen.lkml@gmail.com \
--cc=atomlin@atomlin.com \
--cc=christophe.leroy@csgroup.eu \
--cc=cl@linux.com \
--cc=daniel.thompson@linaro.org \
--cc=hch@infradead.org \
--cc=jason.wessel@windriver.com \
--cc=jeyu@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=msuchanek@suse.de \
--cc=oleksandr@natalenko.name \
--cc=pmladek@suse.com \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).