linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: shuah@kernel.org, linux-kselftest@vger.kernel.org
Cc: gregkh@linuxfoundation.org, tiwai@suse.de,
	tianfei.zhang@intel.com, russell.h.weight@intel.com,
	keescook@chromium.org, tweek@google.com,
	a.manzanares@samsung.com, dave@stgolabs.net,
	linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 1/2] selftests/kmod: increase the kmod timeout from 45 to 165
Date: Mon,  6 Feb 2023 15:43:43 -0800	[thread overview]
Message-ID: <20230206234344.2433950-2-mcgrof@kernel.org> (raw)
In-Reply-To: <20230206234344.2433950-1-mcgrof@kernel.org>

The default sefltests timeout is 45 seconds. If you run the kmod
selftests on your own with say:

./tools/testings/selftests/kmod.sh

Then the default timeout won't be in effect.

I've never ran kmod selftests using the generic make wrapper
(./tools/testing/selftests/run_kselftest.sh -s) util now
that I have support for it on kdevops [0]. And with that the
test is limitted to the default timeout which we quickly run
into. Bump this up to what I see is required on 8GiB / 8 vcpu
libvirt q35 guest as can be easily created now with kdevops.

To run selftests with kdevops:

make menuconfig # enable dedicated selftests and kmod test
make
make bringup
make linux
make selftests-kmod

This ends up taking about 280 seconds now, give or take add
50 seconds more more and we end up with 350. Document the
rationale.

[0] https://github.com/linux-kdevops/kdevops
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 tools/testing/selftests/kmod/settings | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 tools/testing/selftests/kmod/settings

diff --git a/tools/testing/selftests/kmod/settings b/tools/testing/selftests/kmod/settings
new file mode 100644
index 000000000000..6fca0f1a4594
--- /dev/null
+++ b/tools/testing/selftests/kmod/settings
@@ -0,0 +1,4 @@
+# measured from a manual run:
+# time ./tools/testing/selftests/kmod/kmod.sh
+# Then add ~50 seconds more gracetime.
+timeout=350
-- 
2.39.1


  reply	other threads:[~2023-02-06 23:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06 23:43 [PATCH 0/2] selftests: bump timeout for firmware and kmod Luis Chamberlain
2023-02-06 23:43 ` Luis Chamberlain [this message]
2023-02-27 22:32   ` [PATCH 1/2] selftests/kmod: increase the kmod timeout from 45 to 165 Shuah Khan
2023-02-27 22:42     ` Luis Chamberlain
2023-03-03 20:35       ` Shuah Khan
2023-03-03 21:48         ` Luis Chamberlain
2023-03-06 16:06           ` Shuah Khan
2023-03-08 20:29             ` Luis Chamberlain
2023-02-06 23:43 ` [PATCH 2/2] selftests/firmware: increase timeout from 165 to 230 Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230206234344.2433950-2-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=a.manzanares@samsung.com \
    --cc=dave@stgolabs.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=russell.h.weight@intel.com \
    --cc=shuah@kernel.org \
    --cc=tianfei.zhang@intel.com \
    --cc=tiwai@suse.de \
    --cc=tweek@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).