linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nick Alcock <nick.alcock@oracle.com>
To: mcgrof@kernel.org
Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
	Shawn Guo <shawn.guo@linaro.org>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	linux-pci@vger.kernel.org
Subject: [PATCH v2 7/7] kbuild, PCI: dwc: remove MODULE_LICENSE in non-modules
Date: Thu, 16 Feb 2023 15:24:10 +0000	[thread overview]
Message-ID: <20230216152410.4312-8-nick.alcock@oracle.com> (raw)
In-Reply-To: <20230216152410.4312-1-nick.alcock@oracle.com>

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: linux-pci@vger.kernel.org
---
 drivers/pci/controller/dwc/pcie-histb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-histb.c b/drivers/pci/controller/dwc/pcie-histb.c
index 43c27812dd6d..927ae05dc920 100644
--- a/drivers/pci/controller/dwc/pcie-histb.c
+++ b/drivers/pci/controller/dwc/pcie-histb.c
@@ -450,4 +450,3 @@ static struct platform_driver histb_pcie_platform_driver = {
 module_platform_driver(histb_pcie_platform_driver);
 
 MODULE_DESCRIPTION("HiSilicon STB PCIe host controller driver");
-MODULE_LICENSE("GPL v2");
-- 
2.39.1.268.g9de2f9a303


  parent reply	other threads:[~2023-02-16 15:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16 15:24 [PATCH v2 0/7] MODULE_LICENSE removals, first tranche Nick Alcock
2023-02-16 15:24 ` [PATCH v2 1/7] kbuild, PCI: versatile: remove MODULE_LICENSE in non-modules Nick Alcock
2023-02-16 15:24 ` [PATCH v2 2/7] kbuild, PCI: mobiveil: " Nick Alcock
2023-02-16 15:24 ` [PATCH v2 3/7] kbuild, PCI: tegra: " Nick Alcock
2023-02-16 15:24 ` [PATCH v2 4/7] kbuild, PCI: endpoint: " Nick Alcock
2023-02-16 18:11   ` Manivannan Sadhasivam
2023-02-16 15:24 ` [PATCH v2 5/7] kbuild, PCI: hip: " Nick Alcock
2023-02-16 15:24 ` [PATCH v2 6/7] kbuild, shpchp: " Nick Alcock
2023-02-16 15:24 ` Nick Alcock [this message]
2023-02-16 17:43 ` [PATCH v2 0/7] MODULE_LICENSE removals, first tranche Bjorn Helgaas
2023-02-16 18:01   ` Conor Dooley
2023-02-16 19:16     ` Bjorn Helgaas
2023-02-16 23:38       ` Conor Dooley
2023-02-16 19:20   ` Nick Alcock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230216152410.4312-8-nick.alcock@oracle.com \
    --to=nick.alcock@oracle.com \
    --cc=bhelgaas@google.com \
    --cc=broonie@kernel.org \
    --cc=hasegawa-hitomi@fujitsu.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).