Linux Modules
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: linux-modules@vger.kernel.org
Cc: emil.l.velikov@gmail.com
Subject: [PATCH 0/4] kmod: Paper cuts - dead code removal, don't SED manually
Date: Tue, 21 Feb 2023 13:19:25 +0000	[thread overview]
Message-ID: <20230221131929.106951-1-emil.l.velikov@gmail.com> (raw)

Greetings everyone,

Here's another, final, round of paper cuts while browsing through the project.

Note that despite the enabled linker garbage collector, the first few cleanup
patches result in detectable improvement in the final binaries.

The last patch, removes the open-coded replacement and by doing so fixes a
genuine bug - albeit one that is uncommon to hit.

As always, feel free to pick any bits that seem suitable.

Thanks
Emil

Emil Velikov (4):
  libkmod: remove unused kmod_module_get_builtin
  libkmod: annotate kmod_builtin_iter API as static
  shared: annotate local API as static
  configure: manage libkmod.pc.in and version.py.in via AC_CONFIG_FILES

 Makefile.am                | 25 ----------------------
 configure.ac               |  2 ++
 libkmod/libkmod-builtin.c  |  8 +++----
 libkmod/libkmod-internal.h |  6 ------
 libkmod/libkmod-module.c   | 43 --------------------------------------
 shared/util.c              |  6 +++---
 shared/util.h              |  3 ---
 7 files changed, 9 insertions(+), 84 deletions(-)

-- 
2.39.2


             reply	other threads:[~2023-02-21 13:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 13:19 Emil Velikov [this message]
2023-02-21 13:19 ` [PATCH 1/4] libkmod: remove unused kmod_module_get_builtin Emil Velikov
2023-02-21 13:19 ` [PATCH 2/4] libkmod: annotate kmod_builtin_iter API as static Emil Velikov
2023-02-21 13:19 ` [PATCH 3/4] shared: annotate local " Emil Velikov
2023-02-21 13:19 ` [PATCH 4/4] configure: manage libkmod.pc.in and version.py.in via AC_CONFIG_FILES Emil Velikov
2023-02-22  0:40 ` [PATCH 0/4] kmod: Paper cuts - dead code removal, don't SED manually Lucas De Marchi
2023-02-22 11:50   ` Emil Velikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230221131929.106951-1-emil.l.velikov@gmail.com \
    --to=emil.l.velikov@gmail.com \
    --cc=linux-modules@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox