From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-modules-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 958F8C678D5
	for <linux-modules@archiver.kernel.org>; Tue,  7 Mar 2023 19:36:28 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234192AbjCGTg1 (ORCPT
        <rfc822;linux-modules@archiver.kernel.org>);
        Tue, 7 Mar 2023 14:36:27 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45652 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230511AbjCGTgH (ORCPT
        <rfc822;linux-modules@vger.kernel.org>);
        Tue, 7 Mar 2023 14:36:07 -0500
Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [IPv6:2001:4b98:dc4:8::230])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E97D3773D;
        Tue,  7 Mar 2023 11:23:06 -0800 (PST)
Received: (Authenticated sender: miquel.raynal@bootlin.com)
        by mail.gandi.net (Postfix) with ESMTPSA id 410FD240003;
        Tue,  7 Mar 2023 19:23:03 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1;
        t=1678216984;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:
         content-transfer-encoding:content-transfer-encoding:
         in-reply-to:in-reply-to:references:references;
        bh=5P9AcKH+YezSJtK9lbnU6QQK7ZoiMZqMhUgw4Rvj/2o=;
        b=cHoo1ImK0XY8bwtiihM1e2oVZPfFgcF3OA7p5nE/bUeybkFQKAqO4d+x0Fc696mzDdxHnN
        Ppd0L2D0je9SWF/vAf/wkCzvqT5wNOqWfDGc8SkmSUC9Ijtu1+j4a4tQzbK//Khy7ByCNr
        Ysz3PEVZlz0vp/0p+epfAC1pplv6N/XMPRCE+XU1QwEZLTqvERByRL2b4MTk+F/xkQqrQ4
        /9M1u9bWDS2HkPPf7D7c3W+kOEtbDnjgSCxhhzGtWQsGQ5qqTatAqvy7OeA5PGY7Nhvz0V
        8oZnNz997DsBxluk/TYfqz8M2OCzi+iI5XrOSIlrDhPdb+lo8OMXI3qojBEY8g==
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Nick Alcock <nick.alcock@oracle.com>, mcgrof@kernel.org
Cc:     Miquel Raynal <miquel.raynal@bootlin.com>,
        linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org
Subject: Re: [PATCH 18/27] mtd: bcm63xxpart: remove MODULE_LICENSE in non-modules
Date:   Tue,  7 Mar 2023 20:23:02 +0100
Message-Id: <20230307192302.353514-1-miquel.raynal@bootlin.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20230224150811.80316-19-nick.alcock@oracle.com>
References: 
MIME-Version: 1.0
X-linux-mtd-patch-notification: thanks
X-linux-mtd-patch-commit: b'9116000828de4f9973e65a11fd7530dc03d1bdda'
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <linux-modules.vger.kernel.org>

On Fri, 2023-02-24 at 15:08:02 UTC, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.
> 
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: linux-mtd@lists.infradead.org

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel