From: Allen Webb <allenwebb@google.com>
To: "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: gregkh@linuxfoundation.org, mcgrof@kernel.org,
christophe.leroy@csgroup.eu, nick.alcock@oracle.com,
Allen Webb <allenwebb@google.com>
Subject: [PATCH v10 07/11] file2alias.c: Implement builtin.alias generation
Date: Thu, 6 Apr 2023 14:00:26 -0500 [thread overview]
Message-ID: <20230406190030.968972-8-allenwebb@google.com> (raw)
In-Reply-To: <20230406190030.968972-1-allenwebb@google.com>
This populates the mod->modalias_buf with aliases for built-in modules
when modpost is run against vmlinuz.o.
Signed-off-by: Allen Webb <allenwebb@google.com>
---
scripts/mod/file2alias.c | 61 ++++++++++++++++++++++++++--------------
1 file changed, 40 insertions(+), 21 deletions(-)
diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
index b392d51c3b06..3793d4632b94 100644
--- a/scripts/mod/file2alias.c
+++ b/scripts/mod/file2alias.c
@@ -233,6 +233,8 @@ static void do_usb_entry(void *symval,
add_wildcard(alias);
buf_printf(&mod->dev_table_buf,
"MODULE_ALIAS(\"%s\");\n", alias);
+ if (mod->builtin_name)
+ buf_printf(&mod->modalias_buf, "alias %s %s\n", alias, mod->builtin_name);
}
/* Handles increment/decrement of BCD formatted integers */
@@ -377,9 +379,13 @@ static void do_of_entry_multi(void *symval, struct module *mod)
*tmp = '_';
buf_printf(&mod->dev_table_buf, "MODULE_ALIAS(\"%s\");\n", alias);
+ if (mod->builtin_name)
+ buf_printf(&mod->modalias_buf, "alias %s %s\n", alias, mod->builtin_name);
strcat(alias, "C");
add_wildcard(alias);
buf_printf(&mod->dev_table_buf, "MODULE_ALIAS(\"%s\");\n", alias);
+ if (mod->builtin_name)
+ buf_printf(&mod->modalias_buf, "alias %s %s\n", alias, mod->builtin_name);
}
static void do_of_table(void *symval, unsigned long size,
@@ -611,12 +617,18 @@ static void do_pnp_device_entry(void *symval, unsigned long size,
buf_printf(&mod->dev_table_buf,
"MODULE_ALIAS(\"pnp:d%s*\");\n", *id);
+ if (mod->builtin_name)
+ buf_printf(&mod->modalias_buf, "alias pnp:d%s* %s\n",
+ *id, mod->builtin_name);
/* fix broken pnp bus lowercasing */
for (j = 0; j < sizeof(acpi_id); j++)
acpi_id[j] = toupper((*id)[j]);
buf_printf(&mod->dev_table_buf,
"MODULE_ALIAS(\"acpi*:%s:*\");\n", acpi_id);
+ if (mod->builtin_name)
+ buf_printf(&mod->modalias_buf, "alias acpi*:%s:* %s\n",
+ acpi_id, mod->builtin_name);
}
}
@@ -638,6 +650,8 @@ static void do_pnp_card_entries(void *symval, unsigned long size,
const char *id = (char *)(*devs)[j].id;
int i2, j2;
int dup = 0;
+ char acpi_id[PNP_ID_LEN];
+ int k;
if (!id[0])
break;
@@ -663,19 +677,23 @@ static void do_pnp_card_entries(void *symval, unsigned long size,
}
/* add an individual alias for every device entry */
- if (!dup) {
- char acpi_id[PNP_ID_LEN];
- int k;
-
- buf_printf(&mod->dev_table_buf,
- "MODULE_ALIAS(\"pnp:d%s*\");\n", id);
-
- /* fix broken pnp bus lowercasing */
- for (k = 0; k < sizeof(acpi_id); k++)
- acpi_id[k] = toupper(id[k]);
- buf_printf(&mod->dev_table_buf,
- "MODULE_ALIAS(\"acpi*:%s:*\");\n", acpi_id);
- }
+ if (dup)
+ continue;
+
+ buf_printf(&mod->dev_table_buf,
+ "MODULE_ALIAS(\"pnp:d%s*\");\n", id);
+ if (mod->builtin_name)
+ buf_printf(&mod->modalias_buf, "alias pnp:d%s* %s\n",
+ id, mod->builtin_name);
+
+ /* fix broken pnp bus lowercasing */
+ for (k = 0; k < sizeof(acpi_id); k++)
+ acpi_id[k] = toupper(id[k]);
+ buf_printf(&mod->dev_table_buf,
+ "MODULE_ALIAS(\"acpi*:%s:*\");\n", acpi_id);
+ if (mod->builtin_name)
+ buf_printf(&mod->modalias_buf, "alias acpi*:%s:* %s\n",
+ acpi_id, mod->builtin_name);
}
}
}
@@ -1476,10 +1494,13 @@ static void do_table(void *symval, unsigned long size,
size -= id_size;
for (i = 0; i < size; i += id_size) {
- if (do_entry(mod->name, symval+i, alias)) {
- buf_printf(&mod->dev_table_buf,
- "MODULE_ALIAS(\"%s\");\n", alias);
- }
+ if (!do_entry(mod->name, symval + i, alias))
+ continue;
+ buf_printf(&mod->dev_table_buf, "MODULE_ALIAS(\"%s\");\n", alias);
+ if (!mod->builtin_name)
+ continue;
+ buf_printf(&mod->modalias_buf, "alias %s %s\n", alias,
+ mod->builtin_name);
}
}
@@ -1554,10 +1575,8 @@ void handle_moddevtable(struct module *mod, struct elf_info *info,
return;
/*
- * All our symbols are either of form
- * __mod_<name>__<identifier>_device_table
- * or
- * __mod_<name>__<identifier>__kmod_<builtin-name>_device_table
+ * All our symbols are of form
+ * __mod_<name>__<identifier>__kmod_<modname>_device_table
*/
if (strncmp(symname, "__mod_", strlen("__mod_")))
return;
--
2.39.2
next prev parent reply other threads:[~2023-04-06 19:01 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAJzde06+FXNpyBzT+NfS2GCfqEERMkGDpdsmHQj=v1foLJW4Cw@mail.gmail.com>
2022-11-29 22:43 ` [PATCH v3] modules: add modalias file to sysfs for modules Allen Webb
2022-11-30 7:06 ` Greg Kroah-Hartman
2022-11-30 22:14 ` [PATCH v4] " Allen Webb
2022-12-01 4:33 ` kernel test robot
2022-12-01 6:06 ` Greg Kroah-Hartman
2022-12-01 9:46 ` kernel test robot
2022-12-08 2:34 ` [PATCH v3] " Luis Chamberlain
2022-12-08 14:22 ` Allen Webb
2022-12-08 15:20 ` Greg Kroah-Hartman
2022-12-16 22:16 ` [PATCH v7 0/5] Generate modules.builtin.alias from match ids Allen Webb
2022-12-16 22:16 ` [PATCH v7 1/5] module.h: MODULE_DEVICE_TABLE for built-in modules Allen Webb
2022-12-17 3:49 ` kernel test robot
2022-12-17 3:59 ` kernel test robot
2022-12-17 10:05 ` Christophe Leroy
2022-12-19 15:56 ` Allen Webb
2022-12-16 22:17 ` [PATCH v7 2/5] modpost: Track module name " Allen Webb
2022-12-17 10:08 ` Christophe Leroy
2022-12-16 22:17 ` [PATCH v7 3/5] modpost: Add -b option for emitting built-in aliases Allen Webb
2022-12-17 10:10 ` Christophe Leroy
2022-12-16 22:17 ` [PATCH v7 4/5] file2alias.c: Implement builtin.alias generation Allen Webb
2022-12-17 0:47 ` kernel test robot
2022-12-17 3:09 ` kernel test robot
2022-12-17 10:13 ` Christophe Leroy
2022-12-16 22:17 ` [PATCH v7 5/5] build: Add modules.builtin.alias Allen Webb
2022-12-19 19:18 ` [PATCH v8 0/9] Generate modules.builtin.alias from match ids Allen Webb
2022-12-19 19:18 ` [PATCH v8 1/9] imx: Fix typo Allen Webb
2022-12-19 19:21 ` Greg Kroah-Hartman
2022-12-19 19:55 ` Allen Webb
2022-12-19 19:18 ` [PATCH v8 2/9] rockchip-mailbox: " Allen Webb
2022-12-19 19:18 ` [PATCH v8 3/9] scsi/BusLogic: Always include device id table Allen Webb
2022-12-19 19:18 ` [PATCH v8 4/9] stmpe-spi: Fix typo Allen Webb
2022-12-19 19:18 ` [PATCH v8 5/9] module.h: MODULE_DEVICE_TABLE for built-in modules Allen Webb
2022-12-19 19:18 ` [PATCH v8 6/9] modpost: Track module name " Allen Webb
2022-12-19 19:18 ` [PATCH v8 7/9] modpost: Add -b option for emitting built-in aliases Allen Webb
2022-12-19 19:18 ` [PATCH v8 8/9] file2alias.c: Implement builtin.alias generation Allen Webb
2022-12-19 19:18 ` [PATCH v8 9/9] build: Add modules.builtin.alias Allen Webb
2022-12-19 20:06 ` [PATCH v8 0/9] Generate modules.builtin.alias from match ids Luis Chamberlain
2022-12-19 20:42 ` Allen Webb
2022-12-19 20:46 ` [PATCH v9 00/10] " Allen Webb
2022-12-19 20:46 ` [PATCH v9 01/10] imx: Fix typo Allen Webb
2022-12-19 21:23 ` Luis Chamberlain
2022-12-20 6:42 ` Greg Kroah-Hartman
2022-12-20 14:26 ` Allen Webb
2022-12-20 14:32 ` Greg Kroah-Hartman
2022-12-20 14:45 ` Allen Webb
2022-12-19 20:46 ` [PATCH v9 02/10] rockchip-mailbox: " Allen Webb
2022-12-20 6:46 ` Greg Kroah-Hartman
2022-12-20 14:58 ` Allen Webb
2022-12-20 18:12 ` Luis Chamberlain
2022-12-20 18:19 ` Allen Webb
2022-12-20 18:47 ` Luis Chamberlain
2022-12-20 19:49 ` Allen Webb
2022-12-20 20:03 ` Luis Chamberlain
2022-12-20 21:57 ` Allen Webb
2022-12-20 23:09 ` Luis Chamberlain
2022-12-27 17:42 ` Allen Webb
2023-01-10 0:25 ` Luis Chamberlain
2023-01-09 11:54 ` Nick Alcock
2023-01-10 18:20 ` Allen Webb
2022-12-19 20:46 ` [PATCH v9 03/10] scsi/BusLogic: Always include device id table Allen Webb
2022-12-19 20:46 ` [PATCH v9 04/10] stmpe-spi: Fix typo Allen Webb
2022-12-19 20:46 ` [PATCH v9 05/10] module.h: MODULE_DEVICE_TABLE for built-in modules Allen Webb
2022-12-20 6:45 ` Greg Kroah-Hartman
2022-12-20 16:36 ` Allen Webb
2022-12-19 20:46 ` [PATCH v9 06/10] modpost: Track module name " Allen Webb
2022-12-19 20:46 ` [PATCH v9 07/10] modpost: Add -b option for emitting built-in aliases Allen Webb
2022-12-20 6:43 ` Greg Kroah-Hartman
2022-12-20 17:32 ` Allen Webb
2022-12-19 20:46 ` [PATCH v9 08/10] file2alias.c: Implement builtin.alias generation Allen Webb
2022-12-19 20:46 ` [PATCH v9 09/10] build: Add modules.builtin.alias Allen Webb
2022-12-19 20:46 ` [PATCH v9 10/10] docs: Include modules.builtin.alias Allen Webb
2022-12-19 20:49 ` Allen Webb
2022-12-19 21:23 ` Luis Chamberlain
2022-12-19 21:40 ` Allen Webb
2022-12-19 22:07 ` Luis Chamberlain
2022-12-19 22:20 ` Allen Webb
2022-12-19 22:51 ` Luis Chamberlain
2022-12-19 20:46 ` [PATCH v9 10/10] Documentation: " Allen Webb
2023-04-06 19:00 ` [PATCH v10 00/11] Generate modules.builtin.alias from match ids Allen Webb
2023-04-06 19:00 ` [PATCH v10 01/11] rockchip-mailbox: Remove unneeded MODULE_DEVICE_TABLE Allen Webb
2023-04-06 19:00 ` [PATCH v10 02/11] scsi/BusLogic: Always include device id table Allen Webb
2023-04-06 19:00 ` [PATCH v10 03/11] stmpe-spi: Fix MODULE_DEVICE_TABLE entries Allen Webb
2023-05-24 6:52 ` Luis Chamberlain
2023-05-24 6:52 ` Luis Chamberlain
2023-04-06 19:00 ` [PATCH v10 04/11] module.h: MODULE_DEVICE_TABLE for built-in modules Allen Webb
2023-05-24 6:44 ` Luis Chamberlain
2023-04-06 19:00 ` [PATCH v10 05/11] modpost: Track module name " Allen Webb
2023-04-20 9:47 ` Greg KH
2023-05-24 6:50 ` Luis Chamberlain
2023-04-06 19:00 ` [PATCH v10 06/11] modpost: Add -b option for emitting built-in aliases Allen Webb
2023-05-24 6:54 ` Luis Chamberlain
2023-04-06 19:00 ` Allen Webb [this message]
2023-05-24 7:00 ` [PATCH v10 07/11] file2alias.c: Implement builtin.alias generation Luis Chamberlain
2023-04-06 19:00 ` [PATCH v10 08/11] build: Add modules.builtin.alias Allen Webb
2023-05-24 7:02 ` Luis Chamberlain
2023-07-19 19:51 ` Allen Webb
2023-07-26 18:30 ` Luis Chamberlain
2023-04-06 19:00 ` [PATCH v10 09/11] Documentation: Include modules.builtin.alias Allen Webb
2023-04-06 19:00 ` [PATCH v10 10/11] Documentation: Update writing_usb_driver for built-in modules Allen Webb
2023-04-06 19:00 ` [PATCH v10 11/11] Documentation: add USB authorization document to driver-api Allen Webb
2023-04-20 9:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230406190030.968972-8-allenwebb@google.com \
--to=allenwebb@google.com \
--cc=christophe.leroy@csgroup.eu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nick.alcock@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).