Linux Modules
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>,
	linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] module: print module name on refcount error
Date: Mon, 26 Jun 2023 12:32:52 +0200	[thread overview]
Message-ID: <20230626123252.73dbc139@endymion.delvare> (raw)

If module_put() triggers a refcount error, include the culprit
module name in the warning message, to easy further investigation of
the issue.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Suggested-by: Michal Hocko <mhocko@suse.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>
---
 kernel/module/main.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- linux-6.3.orig/kernel/module/main.c
+++ linux-6.3/kernel/module/main.c
@@ -850,7 +850,9 @@ void module_put(struct module *module)
 	if (module) {
 		preempt_disable();
 		ret = atomic_dec_if_positive(&module->refcnt);
-		WARN_ON(ret < 0);	/* Failed to put refcount */
+		WARN(ret < 0,
+		     KERN_WARNING "Failed to put refcount for module %s\n",
+		     module->name);
 		trace_module_put(module, _RET_IP_);
 		preempt_enable();
 	}


-- 
Jean Delvare
SUSE L3 Support

             reply	other threads:[~2023-06-26 10:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-26 10:32 Jean Delvare [this message]
2023-06-28 10:30 ` [PATCH] module: print module name on refcount error Michal Hocko
2023-07-04 12:43   ` Jean Delvare
2023-07-04 13:05     ` Michal Hocko
2023-07-04 14:35       ` Jean Delvare
2023-06-30 23:05 ` Luis Chamberlain
2023-07-01 15:57   ` Jean Delvare
2023-07-03 10:45     ` Jean Delvare
2023-07-03 13:47   ` Michal Hocko
2023-07-07 18:56     ` Luis Chamberlain
2023-07-10  5:43       ` Michal Hocko
2023-07-26 20:59         ` Luis Chamberlain
2023-08-28 12:18           ` Jean Delvare
2023-09-14 19:39             ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230626123252.73dbc139@endymion.delvare \
    --to=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=mhocko@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox