From: Kees Cook <keescook@chromium.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
Luis Chamberlain <mcgrof@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2 0/5] params: harden string ops and allocatio ops
Date: Mon, 2 Oct 2023 09:57:59 -0700 [thread overview]
Message-ID: <202310020957.022F9047F0@keescook> (raw)
In-Reply-To: <20231002124856.2455696-1-andriy.shevchenko@linux.intel.com>
On Mon, Oct 02, 2023 at 03:48:51PM +0300, Andy Shevchenko wrote:
> A couple of patches are for get the string ops, used in the module,
> slightly harden. On top a few cleanups.
>
> Since the main part is rather hardening, I think the Kees' tree is
> the best fit for the series, but I'm open for another option(s).
>
> Changelog v2:
> - dropped the s*printf() --> sysfs_emit() conversion as it revealed
> an issue, i.e. reuse getters with non-page-aligned pointer, which
> would be addressed separately
> - added cover letter and clarified the possible route for the series
> (Luis)
>
> Andy Shevchenko (5):
> params: Introduce the param_unknown_fn type
> params: Do not go over the limit when getting the string length
> params: Use size_add() for kmalloc()
> params: Sort headers
> params: Fix multi-line comment style
Seems like a nice bit of clean-up.
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2023-10-02 16:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 12:48 [PATCH v2 0/5] params: harden string ops and allocatio ops Andy Shevchenko
2023-10-02 12:48 ` [PATCH v2 1/5] params: Introduce the param_unknown_fn type Andy Shevchenko
2023-10-02 12:48 ` [PATCH v2 2/5] params: Do not go over the limit when getting the string length Andy Shevchenko
2023-10-02 16:57 ` Kees Cook
2023-10-02 12:48 ` [PATCH v2 3/5] params: Use size_add() for kmalloc() Andy Shevchenko
2023-10-02 12:48 ` [PATCH v2 4/5] params: Sort headers Andy Shevchenko
2023-10-02 12:48 ` [PATCH v2 5/5] params: Fix multi-line comment style Andy Shevchenko
2023-10-02 16:57 ` Kees Cook [this message]
2023-10-10 23:21 ` [PATCH v2 0/5] params: harden string ops and allocatio ops Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310020957.022F9047F0@keescook \
--to=keescook@chromium.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).