From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: stable@vger.kernel.org, patches@lists.linux.dev,
stable <stable@kernel.org>,
Stefan Lippers-Hollmann <s.l-h@gmx.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Christoph Hellwig <hch@lst.de>,
linux-media@vger.kernel.org, linux-modules@vger.kernel.org,
Luis Chamberlain <mcgrof@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: Re: [PATCH 4.19 178/273] media: dvb: symbol fixup for dvb_attach()
Date: Sat, 7 Oct 2023 13:53:44 +0200 [thread overview]
Message-ID: <2023100730-imprint-follow-56ec@gregkh> (raw)
In-Reply-To: <b12435b2311ada131db05d3cf195b4b5d87708eb.camel@decadent.org.uk>
On Thu, Sep 28, 2023 at 01:36:06AM +0200, Ben Hutchings wrote:
> On Wed, 2023-09-20 at 13:30 +0200, Greg Kroah-Hartman wrote:
> > 4.19-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream.
> >
> > In commit 9011e49d54dc ("modules: only allow symbol_get of
> > EXPORT_SYMBOL_GPL modules") the use of symbol_get is properly restricted
> > to GPL-only marked symbols. This interacts oddly with the DVB logic
> > which only uses dvb_attach() to load the dvb driver which then uses
> > symbol_get().
> >
> > Fix this up by properly marking all of the dvb_attach attach symbols as
> > EXPORT_SYMBOL_GPL().
> [...]
>
> This (and other) backports missed a couple of affected exports:
>
> - sp8870_attach in drivers/media/dvb-frontends/sp8870.c
> (renamed to drivers/staging/media/av7110/sp8870.c upstream)
> - xc2028_attach in drivers/media/tuners/tuner-xc2028.c
> (renamed to drivers/media/tuners/xc2028.c upstream)
Thanks for catching this, fixed up now for 4.14.y and 4.19.y.
greg k-h
prev parent reply other threads:[~2023-10-07 11:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230920112846.440597133@linuxfoundation.org>
2023-09-20 11:30 ` [PATCH 4.19 178/273] media: dvb: symbol fixup for dvb_attach() Greg Kroah-Hartman
2023-09-27 23:36 ` Ben Hutchings
2023-10-07 11:53 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023100730-imprint-follow-56ec@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ben@decadent.org.uk \
--cc=hch@lst.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mchehab@kernel.org \
--cc=patches@lists.linux.dev \
--cc=s.l-h@gmx.de \
--cc=stable@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).