From: Christoph Hellwig <hch@lst.de>
To: Andrew Kanner <andrew.kanner@gmail.com>
Cc: mcgrof@kernel.org, linux-modules@vger.kernel.org,
linux-kernel@vger.kernel.org, hch@lst.de, mchehab@kernel.org
Subject: Re: [PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get()
Date: Thu, 1 Feb 2024 06:29:58 +0100 [thread overview]
Message-ID: <20240201052958.GA14943@lst.de> (raw)
In-Reply-To: <20240131190251.4668-1-andrew.kanner@gmail.com>
On Wed, Jan 31, 2024 at 10:02:52PM +0300, Andrew Kanner wrote:
> Prototype for __symbol_get_gpl() was introduced in the initial git
> commit 1da177e4c3f4 ("Linux-2.6.12-rc2"), but was not used after that.
>
> In commit 9011e49d54dc ("modules: only allow symbol_get of
> EXPORT_SYMBOL_GPL modules") Christoph Hellwig switched __symbol_get()
> to process GPL symbols only, most likely this is what
> __symbol_get_gpl() was designed to do.
>
> We might either define __symbol_get_gpl() as __symbol_get() or remove
> it completely as suggested by Mauro Carvalho Chehab.
Just remove it, there is no need to keep unused funtionality around.
Btw, where did the discussion start? I hope you're not trying to
add new symbol_get users?
next prev parent reply other threads:[~2024-02-01 5:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 19:02 [PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get() Andrew Kanner
2024-02-01 5:29 ` Christoph Hellwig [this message]
2024-02-01 9:29 ` Andrew Kanner
2024-02-01 18:13 ` Luis Chamberlain
2024-02-13 11:10 ` Andrew Kanner
2024-03-12 22:25 ` Luis Chamberlain
2024-03-13 1:12 ` Luis Chamberlain
2024-02-02 7:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201052958.GA14943@lst.de \
--to=hch@lst.de \
--cc=andrew.kanner@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).