Re: [PATCH v2 patch] libkmod: add weak dependecies

[Jose Ignacio Tornos Martinez <jtornosm@redhat.com>]

>> kmod_config_add_weakdep ...
> this is a long function that we may eventually break in smaller pieces
> and share with the softdep parser.
>> weakdep_to_char ...
> ditto for this one
> I'd keep this in a separate patch, but ok.
> things look good here, thanks for doing this
Ok, let me have a look to get more modular functions in a later patch.

> I think next step would be to add some tests to our testsuite to make
> sure we are parsing things correctly. Could you take a look in in
> `git grep softdep` testsuite/ to take inspiration on how to write one
> for weakdep? it seems we only have 1 test for a failure scenrario, but
> we could add more too.
>
>Tests I'm looking for:
>
> 1) make sure we don't load a module due to being a weakdep
> 2) make sure depmod outputs the weakdep correctly
> 3) make sure the weakdep is parsed correctly from the conf file
Ok, I will complete with some tests as you comment in another later patch.
I will try to cover at least what you say.

Regarding the necessary kernel patch I will re-submit it, adding that
the weak procedure is already included in kmod.

Thank you

Best regards
José Ignacio