From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Zheng Yejian <zhengyejian1@huawei.com>,
mcgrof@kernel.org, mhiramat@kernel.org, mark.rutland@arm.com,
mathieu.desnoyers@efficios.com, jpoimboe@kernel.org,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [RFC PATCH] ftrace: Skip __fentry__ location of overridden weak functions
Date: Fri, 7 Jun 2024 11:39:22 -0400 [thread overview]
Message-ID: <20240607113922.17a62f86@rorschach.local.home> (raw)
In-Reply-To: <20240607150228.GR8774@noisy.programming.kicks-ass.net>
On Fri, 7 Jun 2024 17:02:28 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> > There may be following resolutions:
>
> Oh gawd, sodding weak functions again.
>
> I would suggest changing scipts/kallsyms.c to emit readily identifiable
> symbol names for all the weak junk, eg:
>
> __weak_junk_NNNNN
>
> That instantly fixes the immediate problem and Steve's horrid hack can
> go away.
Right. And when I wrote that hack, I specifically said this should be
fixed in kallsyms, and preferably at build time, as that's when the
weak functions should all be resolved.
-- Steve
>
> Additionally, I would add a boot up pass that would INT3 fill all such
> functions and remove/invalidate all
> static_call/static_jump/fentry/alternative entry that is inside of them.
next prev parent reply other threads:[~2024-06-07 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 11:52 [RFC PATCH] ftrace: Skip __fentry__ location of overridden weak functions Zheng Yejian
2024-06-07 15:02 ` Peter Zijlstra
2024-06-07 15:39 ` Steven Rostedt [this message]
2024-06-11 1:56 ` Zheng Yejian
2024-06-11 9:21 ` Peter Zijlstra
2024-06-11 9:36 ` Zheng Yejian
2024-11-13 7:32 ` Dropify
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240607113922.17a62f86@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=bpf@vger.kernel.org \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=zhengyejian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).