From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D28BB76048; Sat, 31 Aug 2024 18:48:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725130101; cv=none; b=o9ieKKW08zvc8v5v7YB5CMj94IqEP7apuVa77AnoQzISh/p8bQuqkuvTAhQFv8iGoef4vjO7HY6KQE27NvgGauz5i6LQx+hrZgfOXbAbSKQtUJx7OiTUGxbup/LscROWx0m2PJSl03UjrnK8FJ/VY6BEsmlhZPDClPMg3Fv8buQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725130101; c=relaxed/simple; bh=vNLx4cr9O3aGVI+0EaJtBOHUEzDm0igOlyxGNzpMucA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T+Ezjgu9XoPj4wALuGo+SqrLuPKVWUD6PMwPe/gTbwaybeQ1TwXP7dUIXqYnnww/kQBAgJT9KufWhPRFPF1Dda+iA/d+e8pMQWqzWsmQXXCna0HXJrqhMDsI88o2bIFOi4wvtSntatDjEieNJzTQhiBZ/qzcTlY/M+QRDRSJ6gg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=IdGO4SuV; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IdGO4SuV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725130099; x=1756666099; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=vNLx4cr9O3aGVI+0EaJtBOHUEzDm0igOlyxGNzpMucA=; b=IdGO4SuVRA4aZdHJieeUN/zaEaA6SHket5aMfYixkzUtBP9FVuzVEa9T b5VlRsSF0szklCyBNVOTuCsdHAuINtddG4PQXV+1Ad+BZuY8WY0X/vKGP XrRES+nSpWrByG5nCymywjLghz5XG/rbu3KHBjJqK5NwhmO3Hrqco5Bo+ GgZ8FKj1AcCQd06qLdIf1FzYfac5kg6Sx+c6v6p+qErKAiNGSP6JXYw7s qfufK7KxWELVE1/Yp6QgXXFll/KBlUyFnGGQzhGUx+VNYlH/3maWRjyIl Rh34offJlkdTLu0sniiPOenWzkngXQHHfPpRP+g1tUH5WWgU9h+3GOAW8 w==; X-CSE-ConnectionGUID: cn4h0VCxTjeH/Tl7g1XnHw== X-CSE-MsgGUID: P2jX8xJiQL2d0nJYR8wqEg== X-IronPort-AV: E=McAfee;i="6700,10204,11181"; a="23332628" X-IronPort-AV: E=Sophos;i="6.10,192,1719903600"; d="scan'208";a="23332628" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2024 11:48:18 -0700 X-CSE-ConnectionGUID: f4mjMjXfRJ+UWxJ+QP6Pfg== X-CSE-MsgGUID: NfQMlSULQLSgc4c+LoHlng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,192,1719903600"; d="scan'208";a="63815430" Received: from lkp-server01.sh.intel.com (HELO 9c6b1c7d3b50) ([10.239.97.150]) by fmviesa006.fm.intel.com with ESMTP; 31 Aug 2024 11:48:15 -0700 Received: from kbuild by 9c6b1c7d3b50 with local (Exim 4.96) (envelope-from ) id 1skT8v-00030o-1V; Sat, 31 Aug 2024 18:48:13 +0000 Date: Sun, 1 Sep 2024 02:47:27 +0800 From: kernel test robot To: Chunhui Li , Luis Chamberlain , Matthias Brugger , AngeloGioacchino Del Regno Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com, Chunhui Li , Xion Wang Subject: Re: [PATCH] module: abort module loading when sysfs setup suffer errors Message-ID: <202409010209.FqYOzYEa-lkp@intel.com> References: <20240830054400.26622-1-chunhui.li@mediatek.com> Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240830054400.26622-1-chunhui.li@mediatek.com> Hi Chunhui, kernel test robot noticed the following build errors: [auto build test ERROR on mcgrof/modules-next] [also build test ERROR on linus/master v6.11-rc5 next-20240830] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Chunhui-Li/module-abort-module-loading-when-sysfs-setup-suffer-errors/20240830-134417 base: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git modules-next patch link: https://lore.kernel.org/r/20240830054400.26622-1-chunhui.li%40mediatek.com patch subject: [PATCH] module: abort module loading when sysfs setup suffer errors config: powerpc-mpc834x_itx_defconfig (https://download.01.org/0day-ci/archive/20240901/202409010209.FqYOzYEa-lkp@intel.com/config) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 46fe36a4295f05d5d3731762e31fc4e6e99863e9) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240901/202409010209.FqYOzYEa-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202409010209.FqYOzYEa-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from kernel/module/sysfs.c:13: In file included from include/linux/kallsyms.h:13: In file included from include/linux/mm.h:2228: include/linux/vmstat.h:517:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 517 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ >> kernel/module/sysfs.c:400:6: error: assigning to 'int' from incompatible type 'void' 400 | err = add_sect_attrs(mod, info); | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ kernel/module/sysfs.c:404:6: error: assigning to 'int' from incompatible type 'void' 404 | err = add_notes_attrs(mod, info); | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning and 2 errors generated. vim +400 kernel/module/sysfs.c 370 371 int mod_sysfs_setup(struct module *mod, 372 const struct load_info *info, 373 struct kernel_param *kparam, 374 unsigned int num_params) 375 { 376 int err; 377 378 err = mod_sysfs_init(mod); 379 if (err) 380 goto out; 381 382 mod->holders_dir = kobject_create_and_add("holders", &mod->mkobj.kobj); 383 if (!mod->holders_dir) { 384 err = -ENOMEM; 385 goto out_unreg; 386 } 387 388 err = module_param_sysfs_setup(mod, kparam, num_params); 389 if (err) 390 goto out_unreg_holders; 391 392 err = module_add_modinfo_attrs(mod); 393 if (err) 394 goto out_unreg_param; 395 396 err = add_usage_links(mod); 397 if (err) 398 goto out_unreg_modinfo_attrs; 399 > 400 err = add_sect_attrs(mod, info); 401 if (err) 402 goto out_unreg_sect_attrs; 403 404 err = add_notes_attrs(mod, info); 405 if (err) 406 goto out_unreg_notes_attrs; 407 408 return 0; 409 410 out_unreg_notes_attrs: 411 remove_notes_attrs(mod); 412 out_unreg_sect_attrs: 413 remove_sect_attrs(mod); 414 out_unreg_modinfo_attrs: 415 module_remove_modinfo_attrs(mod, -1); 416 out_unreg_param: 417 module_param_sysfs_remove(mod); 418 out_unreg_holders: 419 kobject_put(mod->holders_dir); 420 out_unreg: 421 mod_kobject_put(mod); 422 out: 423 return err; 424 } 425 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki