linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Maurer <mmaurer@google.com>
To: masahiroy@kernel.org, ndesaulniers@google.com, ojeda@kernel.org,
	 gary@garyguo.net, mcgrof@kernel.org,
	Alex Gaynor <alex.gaynor@gmail.com>
Cc: rust-for-linux@vger.kernel.org, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org, neal@gompa.dev, marcan@marcan.st,
	j@jannau.net, asahi@lists.linux.dev,
	"Matthew Maurer" <mmaurer@google.com>,
	"Petr Pavlu" <petr.pavlu@suse.com>,
	"Sami Tolvanen" <samitolvanen@google.com>,
	"Daniel Gomez" <da.gomez@samsung.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	linux-modules@vger.kernel.org
Subject: [PATCH v4 12/16] module: Reformat struct for code style
Date: Tue, 24 Sep 2024 21:19:54 +0000	[thread overview]
Message-ID: <20240924212024.540574-13-mmaurer@google.com> (raw)
In-Reply-To: <20240924212024.540574-1-mmaurer@google.com>

Using commas to declare struct members makes adding new members to this
struct not as nice with patch management.

Signed-off-by: Matthew Maurer <mmaurer@google.com>
---
 kernel/module/internal.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/kernel/module/internal.h b/kernel/module/internal.h
index 2ebece8a789f..daef2be83902 100644
--- a/kernel/module/internal.h
+++ b/kernel/module/internal.h
@@ -80,7 +80,12 @@ struct load_info {
 	unsigned int used_pages;
 #endif
 	struct {
-		unsigned int sym, str, mod, vers, info, pcpu;
+		unsigned int sym;
+		unsigned int str;
+		unsigned int mod;
+		unsigned int vers;
+		unsigned int info;
+		unsigned int pcpu;
 	} index;
 };
 
-- 
2.46.1.824.gd892dcdcdd-goog


  parent reply	other threads:[~2024-09-24 21:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240924212024.540574-1-mmaurer@google.com>
2024-09-24 21:19 ` [PATCH v4 01/16] module: Take const arg in validate_section_offset Matthew Maurer
2024-09-25  9:00   ` Daniel Gomez
2024-09-24 21:19 ` [PATCH v4 02/16] module: Factor out elf_validity_ehdr Matthew Maurer
2024-09-24 21:19 ` [PATCH v4 03/16] module: Factor out elf_validity_cache_sechdrs Matthew Maurer
2024-09-24 21:19 ` [PATCH v4 04/16] module: Factor out elf_validity_cache_secstrings Matthew Maurer
2024-09-24 21:19 ` [PATCH v4 05/16] module: Factor out elf_validity_cache_index_info Matthew Maurer
2024-09-24 21:19 ` [PATCH v4 06/16] module: Factor out elf_validity_cache_index_mod Matthew Maurer
2024-09-24 21:19 ` [PATCH v4 07/16] module: Factor out elf_validity_cache_index_sym Matthew Maurer
2024-09-24 21:19 ` [PATCH v4 08/16] module: Factor out elf_validity_cache_index_str Matthew Maurer
2024-09-24 21:19 ` [PATCH v4 09/16] module: Group section index calculations together Matthew Maurer
2024-09-24 21:19 ` [PATCH v4 10/16] module: Factor out elf_validity_cache_strtab Matthew Maurer
2024-09-24 21:19 ` [PATCH v4 11/16] module: Additional validation in elf_validity_cache_strtab Matthew Maurer
2024-09-24 21:19 ` Matthew Maurer [this message]
2024-09-24 21:19 ` [PATCH v4 14/16] modules: Support extended MODVERSIONS info Matthew Maurer
2024-09-25 23:00   ` Sami Tolvanen
2024-09-25 23:42     ` Matthew Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240924212024.540574-13-mmaurer@google.com \
    --to=mmaurer@google.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=asahi@lists.linux.dev \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=da.gomez@samsung.com \
    --cc=gary@garyguo.net \
    --cc=j@jannau.net \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=masahiroy@kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=neal@gompa.dev \
    --cc=ojeda@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=samitolvanen@google.com \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).