linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Suren Baghdasaryan <surenb@google.com>
To: akpm@linux-foundation.org
Cc: kent.overstreet@linux.dev, corbet@lwn.net, arnd@arndb.de,
	 mcgrof@kernel.org, rppt@kernel.org, paulmck@kernel.org,
	thuth@redhat.com,  tglx@linutronix.de, bp@alien8.de,
	xiongwei.song@windriver.com,  ardb@kernel.org, david@redhat.com,
	vbabka@suse.cz, mhocko@suse.com,  hannes@cmpxchg.org,
	roman.gushchin@linux.dev, dave@stgolabs.net,
	 willy@infradead.org, liam.howlett@oracle.com,
	pasha.tatashin@soleen.com,  souravpanda@google.com,
	keescook@chromium.org, dennis@kernel.org,  jhubbard@nvidia.com,
	urezki@gmail.com, hch@infradead.org, petr.pavlu@suse.com,
	 samitolvanen@google.com, da.gomez@samsung.com,
	yuzhao@google.com,  vvvvvv@google.com, rostedt@goodmis.org,
	iamjoonsoo.kim@lge.com,  rientjes@google.com, minchan@google.com,
	kaleshsingh@google.com,  linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,  linux-arch@vger.kernel.org,
	linux-mm@kvack.org,  maple-tree@lists.infradead.org,
	linux-modules@vger.kernel.org,  kernel-team@android.com,
	surenb@google.com
Subject: [PATCH v4 0/6] page allocation tag compression
Date: Wed, 23 Oct 2024 10:07:53 -0700	[thread overview]
Message-ID: <20241023170759.999909-1-surenb@google.com> (raw)

This patchset implements several improvements:
1. Gracefully handles module unloading while there are used allocations
allocated from that module;
2. Provides an option to store page allocation tag references in the
page flags, removing dependency on page extensions and eliminating the
memory overhead from storing page allocation references (~0.2% of total
system memory). This also improves page allocation performance when
CONFIG_MEM_ALLOC_PROFILING is enabled by eliminating page extension
lookup. Page allocation performance overhead is reduced from 41% to 5.5%.

Patch #1 introduces mas_for_each_rev() helper function.

Patch #2 introduces shutdown_mem_profiling() helper function to be used
when disabling memory allocation profiling.

Patch #3 copies module tags into virtually contiguous memory which
serves two purposes:
- Lets us deal with the situation when module is unloaded while there
are still live allocations from that module. Since we are using a copy
version of the tags we can safely unload the module. Space and gaps in
this contiguous memory are managed using a maple tree.
- Enables simple indexing of the tags in the later patches.

Patch #4 changes the way we allocate virtually contiguous memory for
module tags to reserve only vitrual area and populate physical pages
only as needed at module load time.

Patch #5 abstracts page allocation tag reference to simplify later
changes.

Patch #6 adds compression option to the sysctl.vm.mem_profiling boot
parameter for storing page allocation tag references inside page flags
if they fit. If the number of available page flag bits is insufficient
to address all kernel allocations, memory allocation profiling gets
disabled with an appropriate warning.

Patchset applies to mm-unstable.

Changes since v3 [1]:
- rebased over Mike's patchset in mm-unstable
- added Reviewed-by, per Liam Howlett
- limited execmem_vmap to work with EXECMEM_MODULE_DATA only,
per Mike Rapoport
- moved __get_vm_area_node() declaration into mm/internal.h,
per Mike Rapoport
- split parts of reserve_module_tags() into helper functions to make it
more readable, per Mike Rapoport
- introduced shutdown_mem_profiling() to be used when disabling memory
allocation profiling
- replaced CONFIG_PGALLOC_TAG_USE_PAGEFLAGS with a new boot parameter
option, per Michal Hocko
- minor code cleanups and refactoring to make the code more readable
- added VMALLOC and MODULE SUPPORT reviewers I missed before

[1] https://lore.kernel.org/all/20241014203646.1952505-1-surenb@google.com/

Suren Baghdasaryan (6):
  maple_tree: add mas_for_each_rev() helper
  alloc_tag: introduce shutdown_mem_profiling helper function
  alloc_tag: load module tags into separate contiguous memory
  alloc_tag: populate memory for module tags as needed
  alloc_tag: introduce pgtag_ref_handle to abstract page tag references
  alloc_tag: support for page allocation tag compression

 Documentation/mm/allocation-profiling.rst |   7 +-
 include/asm-generic/codetag.lds.h         |  19 +
 include/linux/alloc_tag.h                 |  21 +-
 include/linux/codetag.h                   |  40 +-
 include/linux/execmem.h                   |  10 +
 include/linux/maple_tree.h                |  14 +
 include/linux/mm.h                        |  25 +-
 include/linux/page-flags-layout.h         |   7 +
 include/linux/pgalloc_tag.h               | 197 +++++++--
 include/linux/vmalloc.h                   |   3 +
 kernel/module/main.c                      |  80 ++--
 lib/alloc_tag.c                           | 467 ++++++++++++++++++++--
 lib/codetag.c                             | 104 ++++-
 mm/execmem.c                              |  16 +
 mm/internal.h                             |   6 +
 mm/mm_init.c                              |   5 +-
 mm/vmalloc.c                              |   4 +-
 scripts/module.lds.S                      |   5 +-
 18 files changed, 903 insertions(+), 127 deletions(-)


base-commit: b5d43fad926a3f542cd06f3c9d286f6f489f7129
-- 
2.47.0.105.g07ac214952-goog


             reply	other threads:[~2024-10-23 17:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 17:07 Suren Baghdasaryan [this message]
2024-10-23 17:07 ` [PATCH v4 1/6] maple_tree: add mas_for_each_rev() helper Suren Baghdasaryan
2024-10-23 17:24   ` Pasha Tatashin
2024-10-23 17:07 ` [PATCH v4 2/6] alloc_tag: introduce shutdown_mem_profiling helper function Suren Baghdasaryan
2024-10-23 17:26   ` Pasha Tatashin
2024-10-23 17:07 ` [PATCH v4 3/6] alloc_tag: load module tags into separate contiguous memory Suren Baghdasaryan
2024-10-23 18:05   ` Pasha Tatashin
2024-10-23 17:07 ` [PATCH v4 4/6] alloc_tag: populate memory for module tags as needed Suren Baghdasaryan
2024-10-23 18:28   ` Pasha Tatashin
2024-10-23 17:07 ` [PATCH v4 5/6] alloc_tag: introduce pgtag_ref_handle to abstract page tag references Suren Baghdasaryan
2024-10-23 17:35   ` Pasha Tatashin
2024-10-23 21:00   ` Andrew Morton
2024-10-23 21:09     ` Suren Baghdasaryan
2024-10-24 16:25       ` Suren Baghdasaryan
2024-10-23 17:07 ` [PATCH v4 6/6] alloc_tag: support for page allocation tag compression Suren Baghdasaryan
2024-10-23 18:29   ` Pasha Tatashin
2024-10-24  3:48     ` Suren Baghdasaryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241023170759.999909-1-surenb@google.com \
    --to=surenb@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=da.gomez@samsung.com \
    --cc=dave@stgolabs.net \
    --cc=david@redhat.com \
    --cc=dennis@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=hch@infradead.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=jhubbard@nvidia.com \
    --cc=kaleshsingh@google.com \
    --cc=keescook@chromium.org \
    --cc=kent.overstreet@linux.dev \
    --cc=kernel-team@android.com \
    --cc=liam.howlett@oracle.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=mcgrof@kernel.org \
    --cc=mhocko@suse.com \
    --cc=minchan@google.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=paulmck@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=rppt@kernel.org \
    --cc=samitolvanen@google.com \
    --cc=souravpanda@google.com \
    --cc=tglx@linutronix.de \
    --cc=thuth@redhat.com \
    --cc=urezki@gmail.com \
    --cc=vbabka@suse.cz \
    --cc=vvvvvv@google.com \
    --cc=willy@infradead.org \
    --cc=xiongwei.song@windriver.com \
    --cc=yuzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).