From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA69F218584 for ; Thu, 24 Oct 2024 23:08:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729811284; cv=none; b=FE+JRy+E5ITbFgsESyy8bhp0IAz25n9DvDIUaULxSrWYgTWk+GDFBfkN8UZjRcHh574+4abiFHl28bfMmq9qM/sCtxMszkz+tDXwicU1yuIdjPW6lmRPsk/lUPcP5baGfH7pSWr2ygeSgp1/4Xn8kufPWum9r1ti7nGYESgywTY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729811284; c=relaxed/simple; bh=FIweofO8swal8FliqNKy5jgFXKhTKwfKXelv1+xVPns=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bIx7drcz9zltHD2KTYCgdAPKocW7jLs+QJM/sM9qWnNyTGdffKXnhmLJUWpjhLAEz1VwWcEZTCovvtLZfaJSObubR6i2UgznWxjYWrm+utC8fUZkI0CAtbEkSnSx1dwDswAbifCwhmyx1deGqvZVvKSddxSHoDA5Xoej9IpHWCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=vG2rNyOd; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vG2rNyOd" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-20ca4877690so35985ad.1 for ; Thu, 24 Oct 2024 16:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729811282; x=1730416082; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LwjW5mBSAuFOFhEIlf3utQozI9vTmaDM4dHrZQJtjd0=; b=vG2rNyOdCyiQeuq3KkVpfzNrI7ydLQfSUrb86Z8xnqMOXDoV+eUlHD14fImKUIHadv 7MptuOOCScPUVP7FCiJUGA+7iYyKUbuSwSfP3pIHraT0xjfzvLKLjUrt8oznwdy0YviP aQYEmQimqMUGfyjTbE+3J4EtMhVkGWjvjxpi3hmexPJ4N/oaumFeqrPyWtUayL81A/sj WovH4w1n5Bld0wywds/uPTptA1O4NmsPIhWXVLjxssOn99TfC97hTX/Z3HbfyfUICPiI uBhyUIOlEl8WbGy+NWnZEKFzxdceTVkPyeClNajiXv889lUIWiFQZEc0x0NLIZYK0TND lEkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729811282; x=1730416082; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LwjW5mBSAuFOFhEIlf3utQozI9vTmaDM4dHrZQJtjd0=; b=FX4LNiNMinA3ngm5jyfFC8LMn+1DrSbgoFYdSfDSnIqbyTuF3JgW4+C1Wv+xn3ffLt lsU6v9BgBRwGiA+rHaFZvyZzBInkfrFtlTF0glvJEF1JJGKcRS4Jh8dMugVmV88myYsh AmJ6iTtdJGqGjlC9eql3LC0+A68uJniZIjIAYYj8i4DT4TmZh5k6PgpaQY/a+lOpuej3 PTZ6glDcpEjI+Q1rDYivy1dP7YAEOCPqb0V+IRsyxZkpxOVAm3WVD/QOY6M9IPgryeNq MFKipYAEq5f+oFR+rQa1gkBhF0gqhwkJ1G0oWVhInkpXgSXKDLtejqchY3wlNjIp4kNZ PK0Q== X-Forwarded-Encrypted: i=1; AJvYcCUnKu7BlzZPpDrnmqyLk42uJPJY5JgSXGwA+jy8IKcHqt30r4D9EafoaspHHsmW9UASW1+5iPSRFJfKuexp@vger.kernel.org X-Gm-Message-State: AOJu0YxF5cuVkVzCK6ZSSOMvT1lG6WbEgKSLIPUqlofi8OO0q1wZrsbe kcTfSL+ygJ7d7cEz+2gJGqF/GoYdmEOFbTxGUdgfbzo7b1Tc45Y3aJtSivn3qA== X-Google-Smtp-Source: AGHT+IGPM0ZptJIpwnMZ9CfEcrh9lVIEAKuBohD9dLT7W11XHiulVCeuXJZu5S3Q/78EfDc25LTScg== X-Received: by 2002:a17:902:daca:b0:20c:a659:deba with SMTP id d9443c01a7336-20fc212d688mr1257735ad.4.1729811281798; Thu, 24 Oct 2024 16:08:01 -0700 (PDT) Received: from google.com (164.135.233.35.bc.googleusercontent.com. [35.233.135.164]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e77e48ad66sm2087361a91.4.2024.10.24.16.08.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2024 16:08:01 -0700 (PDT) Date: Thu, 24 Oct 2024 23:07:57 +0000 From: Sami Tolvanen To: Matthew Maurer Cc: Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-kbuild@vger.kernel.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH v7 0/3] Extended MODVERSIONS Support Message-ID: <20241024230757.GD1382412@google.com> References: <20241023-extended-modversions-v7-0-339787b43373@google.com> Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241023-extended-modversions-v7-0-339787b43373@google.com> On Wed, Oct 23, 2024 at 02:31:27AM +0000, Matthew Maurer wrote: > This patch series is intended for use alongside the Implement DWARF > modversions series [1] to enable RUST and MODVERSIONS at the same > time. > > Elsewhere, we've seen a desire for long symbol name support for LTO > symbol names [2], and the previous series came up [3] as a possible > solution rather than hashing, which some have objected [4] to. > > This series adds a MODVERSIONS format which uses a section per column. > This avoids userspace tools breaking if we need to make a similar change > to the format in the future - we would do so by adding a new section, > rather than editing the struct definition. In the new format, the name > section is formatted as a concatenated sequence of NUL-terminated > strings, which allows for arbitrary length names. > > Emitting the extended format is guarded by CONFIG_EXTENDED_MODVERSIONS, > but the kernel always knows how to validate both the original and > extended formats. > > Selecting RUST and MODVERSIONS is now possible if GENDWARFKSYMS is > selected, and will implicitly select EXTENDED_MODVERSIONS. > > This series depends upon the module verification refactor patches [5] > that were split off of v5, and DWARF-based versions [1]. > > linuxppc-dev is requested to look at the ppc-specific munging, > as Luis would like some eyes on there [6]. > > [1] https://lore.kernel.org/lkml/20241008183823.36676-21-samitolvanen@google.com/ > [2] https://lore.kernel.org/lkml/20240605032120.3179157-1-song@kernel.org/ > [3] https://lore.kernel.org/lkml/ZoxbEEsK40ASi1cY@bombadil.infradead.org/ > [4] https://lore.kernel.org/lkml/0b2697fd-7ab4-469f-83a6-ec9ebc701ba0@suse.com/ > [5] https://lore.kernel.org/linux-modules/20241015231651.3851138-1-mmaurer@google.com/T/#t > [6] https://lore.kernel.org/lkml/ZxahDv5ZKdM__0sZ@bombadil.infradead.org/ > > Changes in v7: > - Fix modpost to detect EXTENDED_MODVERSIONS based on a flag > - Drop patches to fix export_report.pl Unless Luis prefers to deal with this separately, perhaps you can just include a patch to delete export_report.pl in this series? Sami