linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sami Tolvanen <samitolvanen@google.com>
To: Masahiro Yamada <masahiroy@kernel.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	 Miguel Ojeda <ojeda@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Matthew Maurer <mmaurer@google.com>,
	Alex Gaynor <alex.gaynor@gmail.com>,  Gary Guo <gary@garyguo.net>,
	Petr Pavlu <petr.pavlu@suse.com>,
	 Daniel Gomez <da.gomez@samsung.com>, Neal Gompa <neal@gompa.dev>,
	Hector Martin <marcan@marcan.st>,  Janne Grunau <j@jannau.net>,
	Miroslav Benes <mbenes@suse.cz>,
	Asahi Linux <asahi@lists.linux.dev>,
	 Sedat Dilek <sedat.dilek@gmail.com>,
	linux-kbuild@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-modules@vger.kernel.org,  rust-for-linux@vger.kernel.org,
	Sami Tolvanen <samitolvanen@google.com>
Subject: [PATCH v5 08/19] gendwarfksyms: Expand array_type
Date: Wed, 30 Oct 2024 17:01:15 +0000	[thread overview]
Message-ID: <20241030170106.1501763-29-samitolvanen@google.com> (raw)
In-Reply-To: <20241030170106.1501763-21-samitolvanen@google.com>

Add support for expanding DW_TAG_array_type, and the subrange type
indicating array size.

Example source code:

  const char *s[34];

Output with --dump-dies:

  variable array_type[34] {
    pointer_type {
      const_type {
        base_type char byte_size(1) encoding(6)
      }
    } byte_size(8)
  }

Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Acked-by: Neal Gompa <neal@gompa.dev>
Reviewed-by: Petr Pavlu <petr.pavlu@suse.com>
---
 scripts/gendwarfksyms/dwarf.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/scripts/gendwarfksyms/dwarf.c b/scripts/gendwarfksyms/dwarf.c
index 7e6b477d7c12..ade9b3b7b119 100644
--- a/scripts/gendwarfksyms/dwarf.c
+++ b/scripts/gendwarfksyms/dwarf.c
@@ -219,6 +219,7 @@ DEFINE_PROCESS_UDATA_ATTRIBUTE(encoding)
 	}
 
 DEFINE_MATCH(formal_parameter)
+DEFINE_MATCH(subrange)
 
 bool match_all(Dwarf_Die *die)
 {
@@ -341,6 +342,33 @@ DEFINE_PROCESS_TYPE(shared)
 DEFINE_PROCESS_TYPE(volatile)
 DEFINE_PROCESS_TYPE(typedef)
 
+static void process_subrange_type(struct state *state, struct die *cache,
+				  Dwarf_Die *die)
+{
+	Dwarf_Word count = 0;
+
+	if (get_udata_attr(die, DW_AT_count, &count))
+		process_fmt(cache, "[%" PRIu64 "]", count);
+	else if (get_udata_attr(die, DW_AT_upper_bound, &count))
+		process_fmt(cache, "[%" PRIu64 "]", count + 1);
+	else
+		process(cache, "[]");
+}
+
+static void process_array_type(struct state *state, struct die *cache,
+			       Dwarf_Die *die)
+{
+	process(cache, "array_type");
+	/* Array size */
+	check(process_die_container(state, cache, die, process_type,
+				    match_subrange_type));
+	process(cache, " {");
+	process_linebreak(cache, 1);
+	process_type_attr(state, cache, die);
+	process_linebreak(cache, -1);
+	process(cache, "}");
+}
+
 static void __process_subroutine_type(struct state *state, struct die *cache,
 				      Dwarf_Die *die, const char *type)
 {
@@ -436,7 +464,9 @@ static int process_type(struct state *state, struct die *parent, Dwarf_Die *die)
 	PROCESS_TYPE(volatile)
 	/* Subtypes */
 	PROCESS_TYPE(formal_parameter)
+	PROCESS_TYPE(subrange)
 	/* Other types */
+	PROCESS_TYPE(array)
 	PROCESS_TYPE(base)
 	PROCESS_TYPE(subroutine)
 	PROCESS_TYPE(typedef)
-- 
2.47.0.163.g1226f6d8fa-goog


  parent reply	other threads:[~2024-10-30 17:01 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 17:01 [PATCH v5 00/19] Implement DWARF modversions Sami Tolvanen
2024-10-30 17:01 ` [PATCH v5 01/19] scripts: move genksyms crc32 implementation to a common include Sami Tolvanen
2024-11-12  4:05   ` Masahiro Yamada
2024-11-13 14:04     ` Neal Gompa
2024-11-13 19:35       ` Luis Chamberlain
2024-11-14  1:08         ` Neal Gompa
2024-11-13 17:53     ` Sami Tolvanen
2024-11-16  9:08       ` Masahiro Yamada
2024-11-18 21:58         ` Sami Tolvanen
2024-11-19 20:48           ` Darrick J. Wong
2024-11-19 21:37             ` Sami Tolvanen
2024-10-30 17:01 ` [PATCH v5 02/19] tools: Add gendwarfksyms Sami Tolvanen
2024-10-30 17:01 ` [PATCH v5 03/19] gendwarfksyms: Add address matching Sami Tolvanen
2024-10-30 17:01 ` [PATCH v5 04/19] gendwarfksyms: Expand base_type Sami Tolvanen
2024-10-30 17:01 ` [PATCH v5 05/19] gendwarfksyms: Add a cache for processed DIEs Sami Tolvanen
2024-10-30 17:01 ` [PATCH v5 06/19] gendwarfksyms: Expand type modifiers and typedefs Sami Tolvanen
2024-10-30 17:01 ` [PATCH v5 07/19] gendwarfksyms: Expand subroutine_type Sami Tolvanen
2024-10-30 17:01 ` Sami Tolvanen [this message]
2024-10-30 17:01 ` [PATCH v5 09/19] gendwarfksyms: Expand structure types Sami Tolvanen
2024-10-30 17:01 ` [PATCH v5 10/19] gendwarfksyms: Limit structure expansion Sami Tolvanen
2024-11-20 21:54   ` Sami Tolvanen
2024-10-30 17:01 ` [PATCH v5 11/19] gendwarfksyms: Add die_map debugging Sami Tolvanen
2024-10-30 17:01 ` [PATCH v5 12/19] gendwarfksyms: Add symtypes output Sami Tolvanen
2024-10-30 17:01 ` [PATCH v5 13/19] gendwarfksyms: Add symbol versioning Sami Tolvanen
2024-10-30 17:01 ` [PATCH v5 14/19] gendwarfksyms: Add support for kABI rules Sami Tolvanen
2024-10-30 17:01 ` [PATCH v5 15/19] gendwarfksyms: Add support for reserved and ignored fields Sami Tolvanen
2024-10-30 17:01 ` [PATCH v5 16/19] gendwarfksyms: Add support for symbol type pointers Sami Tolvanen
2024-10-30 17:01 ` [PATCH v5 17/19] export: Add __gendwarfksyms_ptr_ references to exported symbols Sami Tolvanen
2024-10-30 17:01 ` [PATCH v5 18/19] kbuild: Add gendwarfksyms as an alternative to genksyms Sami Tolvanen
2024-11-12  4:08   ` Masahiro Yamada
2024-11-13 17:48     ` Sami Tolvanen
2024-10-30 17:01 ` [PATCH v5 19/19] Documentation/kbuild: Add DWARF module versioning Sami Tolvanen
2024-10-30 20:59 ` [PATCH v5 00/19] Implement DWARF modversions Sedat Dilek
2024-10-30 21:14   ` Sami Tolvanen
2024-10-31  1:56     ` Sedat Dilek
2024-10-31  6:18       ` Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241030170106.1501763-29-samitolvanen@google.com \
    --to=samitolvanen@google.com \
    --cc=alex.gaynor@gmail.com \
    --cc=asahi@lists.linux.dev \
    --cc=da.gomez@samsung.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=j@jannau.net \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=masahiroy@kernel.org \
    --cc=mbenes@suse.cz \
    --cc=mcgrof@kernel.org \
    --cc=mmaurer@google.com \
    --cc=neal@gompa.dev \
    --cc=ojeda@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=sedat.dilek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).