linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sami Tolvanen <samitolvanen@google.com>
To: Masahiro Yamada <masahiroy@kernel.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	 Miguel Ojeda <ojeda@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Matthew Maurer <mmaurer@google.com>,
	Alex Gaynor <alex.gaynor@gmail.com>,  Gary Guo <gary@garyguo.net>,
	Petr Pavlu <petr.pavlu@suse.com>,
	 Daniel Gomez <da.gomez@samsung.com>, Neal Gompa <neal@gompa.dev>,
	Hector Martin <marcan@marcan.st>,  Janne Grunau <j@jannau.net>,
	Miroslav Benes <mbenes@suse.cz>,
	Asahi Linux <asahi@lists.linux.dev>,
	 Sedat Dilek <sedat.dilek@gmail.com>,
	linux-kbuild@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-modules@vger.kernel.org,  rust-for-linux@vger.kernel.org,
	Sami Tolvanen <samitolvanen@google.com>
Subject: [PATCH v7 16/18] export: Add __gendwarfksyms_ptr_ references to exported symbols
Date: Thu, 19 Dec 2024 21:07:53 +0000	[thread overview]
Message-ID: <20241219210736.2990838-36-samitolvanen@google.com> (raw)
In-Reply-To: <20241219210736.2990838-20-samitolvanen@google.com>

With gendwarfksyms, we need each TU where the EXPORT_SYMBOL() macro
is used to also contain DWARF type information for the symbols it
exports.  However, as a TU can also export external symbols and
compilers may choose not to emit debugging information for symbols not
defined in the current TU, the missing types will result in missing
symbol versions. Stand-alone assembly code also doesn't contain type
information for exported symbols, so we need to compile a temporary
object file with asm-prototypes.h instead, and similarly need to
ensure the DWARF in the temporary object file contains the necessary
types.

To always emit type information for external exports, add explicit
__gendwarfksyms_ptr_<symbol> references to them in EXPORT_SYMBOL().
gendwarfksyms will use the type information for __gendwarfksyms_ptr_*
if needed. Discard the pointers from the final binary to avoid further
bloat.

Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
---
 include/linux/export.h | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/include/linux/export.h b/include/linux/export.h
index 2633df4d31e6..a8c23d945634 100644
--- a/include/linux/export.h
+++ b/include/linux/export.h
@@ -52,9 +52,24 @@
 
 #else
 
+#ifdef CONFIG_GENDWARFKSYMS
+/*
+ * With CONFIG_GENDWARFKSYMS, ensure the compiler emits debugging
+ * information for all exported symbols, including those defined in
+ * different TUs, by adding a __gendwarfksyms_ptr_<symbol> pointer
+ * that's discarded during the final link.
+ */
+#define __GENDWARFKSYMS_EXPORT(sym)				\
+	static typeof(sym) *__gendwarfksyms_ptr_##sym __used	\
+		__section(".discard.gendwarfksyms") = &sym;
+#else
+#define __GENDWARFKSYMS_EXPORT(sym)
+#endif
+
 #define __EXPORT_SYMBOL(sym, license, ns)			\
 	extern typeof(sym) sym;					\
 	__ADDRESSABLE(sym)					\
+	__GENDWARFKSYMS_EXPORT(sym)				\
 	asm(__stringify(___EXPORT_SYMBOL(sym, license, ns)))
 
 #endif
-- 
2.47.1.613.gc27f4b7a9f-goog


  parent reply	other threads:[~2024-12-19 21:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-19 21:07 [PATCH v7 00/18] Implement DWARF modversions Sami Tolvanen
2024-12-19 21:07 ` [PATCH v7 01/18] tools: Add gendwarfksyms Sami Tolvanen
2024-12-27  6:01   ` Masahiro Yamada
2025-01-02 21:12     ` Sami Tolvanen
2024-12-19 21:07 ` [PATCH v7 02/18] gendwarfksyms: Add address matching Sami Tolvanen
2024-12-28 16:28   ` Masahiro Yamada
2025-01-02 21:20     ` Sami Tolvanen
2024-12-19 21:07 ` [PATCH v7 03/18] gendwarfksyms: Expand base_type Sami Tolvanen
2024-12-19 21:07 ` [PATCH v7 04/18] gendwarfksyms: Add a cache for processed DIEs Sami Tolvanen
2024-12-19 21:07 ` [PATCH v7 05/18] gendwarfksyms: Expand type modifiers and typedefs Sami Tolvanen
2024-12-19 21:07 ` [PATCH v7 06/18] gendwarfksyms: Expand subroutine_type Sami Tolvanen
2024-12-19 21:07 ` [PATCH v7 07/18] gendwarfksyms: Expand array_type Sami Tolvanen
2024-12-19 21:07 ` [PATCH v7 08/18] gendwarfksyms: Expand structure types Sami Tolvanen
2024-12-19 21:07 ` [PATCH v7 09/18] gendwarfksyms: Limit structure expansion Sami Tolvanen
2024-12-19 21:07 ` [PATCH v7 10/18] gendwarfksyms: Add die_map debugging Sami Tolvanen
2024-12-19 21:07 ` [PATCH v7 11/18] gendwarfksyms: Add symtypes output Sami Tolvanen
2024-12-19 21:07 ` [PATCH v7 12/18] gendwarfksyms: Add symbol versioning Sami Tolvanen
2024-12-19 21:07 ` [PATCH v7 13/18] gendwarfksyms: Add support for kABI rules Sami Tolvanen
2024-12-19 21:07 ` [PATCH v7 14/18] gendwarfksyms: Add support for reserved and ignored fields Sami Tolvanen
2024-12-19 21:07 ` [PATCH v7 15/18] gendwarfksyms: Add support for symbol type pointers Sami Tolvanen
2024-12-19 21:07 ` Sami Tolvanen [this message]
2024-12-19 21:07 ` [PATCH v7 17/18] kbuild: Add gendwarfksyms as an alternative to genksyms Sami Tolvanen
2024-12-19 21:07 ` [PATCH v7 18/18] Documentation/kbuild: Add DWARF module versioning Sami Tolvanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241219210736.2990838-36-samitolvanen@google.com \
    --to=samitolvanen@google.com \
    --cc=alex.gaynor@gmail.com \
    --cc=asahi@lists.linux.dev \
    --cc=da.gomez@samsung.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=j@jannau.net \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=masahiroy@kernel.org \
    --cc=mbenes@suse.cz \
    --cc=mcgrof@kernel.org \
    --cc=mmaurer@google.com \
    --cc=neal@gompa.dev \
    --cc=ojeda@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=sedat.dilek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).